feat(linter): introduce ExternalLinter struct

[camc314]

No description provided.

[camc314]

• feat(linter): load custom JS plugins #11980
• feat(linter): introduce ExternalLinter struct #12052 👈 (View in Graphite)
• refactor(linter): mark napi::lint as async #12050
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12052 will improve performances by 15.02%

_{Comparing c/07-03-feat_linter_introduce_externallinter_struct (f81d336) with main (a257d97)}

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	mangler[cal.com.tsx]	3.5 ms	3.1 ms	+15.02%

[overlookmotel]

Aside from the linker error on Linux, all looks good.

My only comment is that maybe it'd be preferable to keep napi out of oxc_linter crate.

I'm not really clear on where the split of responsibilities is between apps/oxlint and crates/oxc_linter, or why we have that separation. But since we do have that separation, it might be preferable to keep napi stuff in the napi/oxlint2 package.

Could ExternalLinter contain normal tokio async functions, and napi/oxlint2 creates an ExternalLinter containing async functions which call the ThreadsafeFunctions internally?

Note: I don't propose changing this PR, but just a thought for next iteration.

[overlookmotel]

Merge activity

• Jul 3, 7:48 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 3, 7:48 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Jul 3, 7:57 PM UTC: Merged by the Graphite merge queue.