Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 10, 2025

Add an error type AllocError, instead of using bumpalo's error types. This is preparation for replacing bumpalo with our own allocator.

Copy link
Member Author

overlookmotel commented Jul 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 10, 2025
@overlookmotel overlookmotel marked this pull request as ready for review July 10, 2025 19:14
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 10, 2025

CodSpeed Instrumentation Performance Report

Merging #12204 will not alter performance

Comparing 07-10-refactor_allocator_add_error_type_to_rawvec_ (6ff6643) with 07-10-refactor_allocator_remove_dead_code_from_vec_ (a9482f2)

Summary

✅ 34 untouched benchmarks

@overlookmotel overlookmotel changed the base branch from 07-10-refactor_allocator_remove_dead_code_from_vec_ to graphite-base/12204 July 10, 2025 19:29
@overlookmotel overlookmotel force-pushed the 07-10-refactor_allocator_add_error_type_to_rawvec_ branch from f7d724c to c7a8260 Compare July 10, 2025 19:46
@overlookmotel overlookmotel changed the base branch from graphite-base/12204 to 07-10-refactor_allocator_remove_dead_code_from_vec_ July 10, 2025 19:46
@graphite-app graphite-app bot force-pushed the 07-10-refactor_allocator_remove_dead_code_from_vec_ branch from 41d2db9 to ea654d9 Compare July 10, 2025 20:21
@graphite-app graphite-app bot requested a review from Dunqing as a code owner July 10, 2025 20:21
@graphite-app graphite-app bot force-pushed the 07-10-refactor_allocator_remove_dead_code_from_vec_ branch from ea654d9 to ae8faf0 Compare July 10, 2025 20:22
@graphite-app graphite-app bot force-pushed the 07-10-refactor_allocator_add_error_type_to_rawvec_ branch from c7a8260 to b2066c3 Compare July 10, 2025 20:22
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 11, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 11, 2025

Merge activity

Add an error type `AllocError`, instead of using `bumpalo`'s error types. This is preparation for replacing `bumpalo` with our own allocator.
@graphite-app graphite-app bot force-pushed the 07-10-refactor_allocator_remove_dead_code_from_vec_ branch from ae8faf0 to a9482f2 Compare July 11, 2025 00:55
@graphite-app graphite-app bot force-pushed the 07-10-refactor_allocator_add_error_type_to_rawvec_ branch from b2066c3 to 6ff6643 Compare July 11, 2025 00:56
Base automatically changed from 07-10-refactor_allocator_remove_dead_code_from_vec_ to main July 11, 2025 01:04
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 11, 2025
@graphite-app graphite-app bot merged commit 6ff6643 into main Jul 11, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 07-10-refactor_allocator_add_error_type_to_rawvec_ branch July 11, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants