fix(allocator)!: remove vec! macro
#12206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12206 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
07-10-docs_allocator_extend_doc_comments_for_vec_and_rawvec_
branch
from
948cdec to
80e6946
Compare
overlookmotel
force-pushed
the
07-10-fix_allocator_remove_vec_macro
branch
from
077d2e7 to
64b2d05
Compare
graphite-app
bot
force-pushed
the
07-10-docs_allocator_extend_doc_comments_for_vec_and_rawvec_
branch
from
80e6946 to
c6a8eea
Compare
graphite-app
bot
force-pushed
the
07-10-fix_allocator_remove_vec_macro
branch
from
64b2d05 to
8a4f7c5
Compare
Dunqing
approved these changes
Jul 11, 2025
Member
Merge activity
|
Remove `vec!` macro from `oxc_allocator`. This is in the `vec2::raw_vec` module, but is accidentally exposed due to the `#[macro_export]` attribute. This macro creates a `bumpalo::collections::Vec`, instead of our own `Vec` type, which is confusing. We could add a `vec!` macro which creates our own `Vec` type, but that's not completely trivial (how to handle cloning `item` in `vec![item; 3]`? `Clone` or `CloneIn`?). So for now, just remove this erroneous macro entirely.
graphite-app
bot
force-pushed
the
07-10-docs_allocator_extend_doc_comments_for_vec_and_rawvec_
branch
from
c6a8eea to
b3a076b
Compare
graphite-app
bot
force-pushed
the
07-10-fix_allocator_remove_vec_macro
branch
from
8a4f7c5 to
facd3cd
Compare
Base automatically changed from
07-10-docs_allocator_extend_doc_comments_for_vec_and_rawvec_
to
main
July 11, 2025 01:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
vec!macro fromoxc_allocator. This is in thevec2::raw_vecmodule, but is accidentally exposed due to the#[macro_export]attribute.This macro creates a
bumpalo::collections::Vec, instead of our ownVectype, which is confusing.We could add a
vec!macro which creates our ownVectype, but that's not completely trivial (how to handle cloningiteminvec![item; 3]?CloneorCloneIn?). So for now, just remove this erroneous macro entirely.