perf(transformer/styled-components): remove quasis and expressions in batch #12256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
changed the title
github-actions
bot
added
the
C-performance
Dunqing
force-pushed
the
07-14-pref_transformer_styled-components_remove_quasis_and_expressions_in_batch
branch
from
7459b4d to
b20f2ab
Compare
CodSpeed Instrumentation Performance ReportMerging #12256 will not alter performanceComparing Summary
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
graphite-app
bot
changed the base branch from
07-12-fix_transform_styled-components_fix_spans_of_quasis_when_some_quasis_removed
to
graphite-base/12256
graphite-app
bot
force-pushed
the
graphite-base/12256
branch
from
8152fe7 to
fb76e3c
Compare
graphite-app
bot
force-pushed
the
07-14-pref_transformer_styled-components_remove_quasis_and_expressions_in_batch
branch
from
b20f2ab to
f76ca34
Compare
graphite-app
bot
force-pushed
the
07-14-pref_transformer_styled-components_remove_quasis_and_expressions_in_batch
branch
from
f76ca34 to
85bdee6
Compare
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
As you say, this case is uncommon, but yes using retain is ideal to avoid poor perf in odd cases where there are tons of quasis and many get deleted. 👍
If we do #12213, then probably we'll be able to make the main loop use retain, and then we won't need the extra loops to remove nodes at the end.
Dunqing
force-pushed
the
07-14-pref_transformer_styled-components_remove_quasis_and_expressions_in_batch
branch
from
85bdee6 to
505b8db
Compare
Member
Merge activity
|
… batch (#12256) Remove `quasis` and `expressions` in batch instead of removing them one by one, so that it would be more efficient. Considering that the expression's removal is unlikely to be common, I add a `has_deletion_marker` flag to avoid unnecessary `retain` calls, so that we can keep the performance as before in this situation.
graphite-app
bot
force-pushed
the
07-14-pref_transformer_styled-components_remove_quasis_and_expressions_in_batch
branch
from
505b8db to
a8d1e22
Compare
graphite-app
bot
deleted the
07-14-pref_transformer_styled-components_remove_quasis_and_expressions_in_batch
branch
This was referenced Jul 15, 2025
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Follow-on after #12256. Update comments to reflect the new removal logic. Also tidy up some other comments.
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Follow-on after #12256. Nit! Rename var to a name which reflects what the var *means*, rather than the implementation detail.
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Follow-on after #12256. Optimize the `retain` loop for removing quasis and expressions by doing bounds check only once at start, rather than on each turn of the loop.
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Follow-on after #12256. Optimize the `retain` loop for removing quasis and expressions by doing bounds check only once at start, rather than on each turn of the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
quasisandexpressionsin batch instead of removing them one by one, so that it would be more efficient. Considering that the expression's removal is unlikely to be common, I add ahas_deletion_markerflag to avoid unnecessaryretaincalls, so that we can keep the performance as before in this situation.