perf(transform/styled-components): optimize removal loop #12284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-performance
This was referenced Jul 15, 2025
CodSpeed Instrumentation Performance ReportMerging #12284 will not alter performanceComparing Summary
|
This was referenced Jul 15, 2025
Dunqing
approved these changes
Jul 15, 2025
Member
Dunqing
left a comment
Dunqing
left a comment
There was a problem hiding this comment.
Hey man, you don't let go of any instruction that can be removed.
Member
Merge activity
|
Member
Author
|
Yeah maybe I am too obsessive! |
graphite-app
bot
changed the base branch from
07-15-refactor_transform_styled-components_rename_var
to
graphite-base/12284
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Follow-on after #12256. Optimize the `retain` loop for removing quasis and expressions by doing bounds check only once at start, rather than on each turn of the loop.
graphite-app
bot
force-pushed
the
07-15-perf_transform_styled-components_optimize_removal_loop
branch
from
f2ba59f to
f87da67
Compare
github-actions
bot
added
A-linter
graphite-app
bot
changed the base branch from
graphite-base/12284
to
07-15-refactor_transform_styled-components_rename_var
Base automatically changed from
07-15-refactor_transform_styled-components_rename_var
to
main
July 15, 2025 17:44
overlookmotel
force-pushed
the
07-15-perf_transform_styled-components_optimize_removal_loop
branch
from
f87da67 to
08f8979
Compare
Follow-on after #12256. Optimize the `retain` loop for removing quasis and expressions by doing bounds check only once at start, rather than on each turn of the loop.
graphite-app
bot
force-pushed
the
07-15-perf_transform_styled-components_optimize_removal_loop
branch
from
08f8979 to
5ecf5c4
Compare
overlookmotel
added
0-merge
Member
Author
|
What the hell going on with this stack? Graphite keeps refusing to merge it even though CI passes. And who added every single label to this PR? |
graphite-app
bot
deleted the
07-15-perf_transform_styled-components_optimize_removal_loop
branch
Member
No! This way can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on after #12256. Optimize the
retainloop for removing quasis and expressions by doing bounds check only once at start, rather than on each turn of the loop.