Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 14, 2025

Do not compile code for fixed-sized allocators (for raw transfer) on unsupported systems (32 bit, or big-endian).

This allows removing the workaround to prevent compilation failure on 32-bit systems due to 1 << 32 overflowing usize. This code is no longer compiled on 32-bit systems.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 14, 2025
Copy link
Member Author

overlookmotel commented Jul 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel force-pushed the 07-14-refactor_napi_parser_do_not_compile_raw_transfer_code_on_wasm branch from c86b147 to b794877 Compare July 14, 2025 17:54
@overlookmotel overlookmotel force-pushed the 07-14-refactor_allocator_disable_fixed_size_allocators_on_unsupported_platforms branch from 30c731c to 79c6a45 Compare July 14, 2025 17:54
@overlookmotel overlookmotel marked this pull request as ready for review July 14, 2025 17:57
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 14, 2025

CodSpeed Instrumentation Performance Report

Merging #12272 will not alter performance

Comparing 07-14-refactor_allocator_disable_fixed_size_allocators_on_unsupported_platforms (f130a0c) with main (c995fe2)

Summary

✅ 34 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 14, 2025
Copy link
Member Author

overlookmotel commented Jul 14, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from 07-14-refactor_napi_parser_do_not_compile_raw_transfer_code_on_wasm to graphite-base/12272 July 14, 2025 18:11
@graphite-app graphite-app bot changed the base branch from graphite-base/12272 to main July 14, 2025 18:20
…tforms (#12272)

Do not compile code for fixed-sized allocators (for raw transfer) on unsupported systems (32 bit, or big-endian).

This allows removing the workaround to prevent compilation failure on 32-bit systems due to `1 << 32` overflowing `usize`. This code is no longer compiled on 32-bit systems.
@graphite-app graphite-app bot force-pushed the 07-14-refactor_allocator_disable_fixed_size_allocators_on_unsupported_platforms branch from 79c6a45 to f130a0c Compare July 14, 2025 18:21
@graphite-app graphite-app bot merged commit f130a0c into main Jul 14, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-14-refactor_allocator_disable_fixed_size_allocators_on_unsupported_platforms branch July 14, 2025 18:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants