Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 14, 2025

Similar to #12268. Instead of hard-coding the size and alignment of raw transfer buffers in multiple places, codegen add these to generated files, and everywhere else import the values from those files. This is more robust.

Copy link
Member Author

overlookmotel commented Jul 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 14, 2025 18:45
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 14, 2025
Copy link
Member Author

overlookmotel commented Jul 14, 2025

Merge activity

  • Jul 14, 6:46 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 14, 7:28 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 14, 7:28 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Jul 14, 7:45 PM UTC: Merged by the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 14, 2025

CodSpeed Instrumentation Performance Report

Merging #12275 will not alter performance

Comparing 07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts (39ef911) with main (c68b607)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from 07-14-refactor_napi_parser_raw_transfer_store_offsets_as_consts to graphite-base/12275 July 14, 2025 18:57
@graphite-app graphite-app bot force-pushed the graphite-base/12275 branch from a3f85ed to d009bdb Compare July 14, 2025 19:05
@graphite-app graphite-app bot force-pushed the 07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts branch from 262097f to da6d05d Compare July 14, 2025 19:05
@graphite-app graphite-app bot changed the base branch from graphite-base/12275 to main July 14, 2025 19:06
@graphite-app graphite-app bot force-pushed the 07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts branch from da6d05d to 0636080 Compare July 14, 2025 19:06
@overlookmotel overlookmotel added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jul 14, 2025
… align as consts (#12275)

Similar to #12268. Instead of hard-coding the size and alignment of raw transfer buffers in multiple places, codegen add these to generated files, and everywhere else import the values from those files. This is more robust.
@graphite-app graphite-app bot force-pushed the 07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts branch from 0636080 to 39ef911 Compare July 14, 2025 19:36
@graphite-app graphite-app bot merged commit 39ef911 into main Jul 14, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 14, 2025
@graphite-app graphite-app bot deleted the 07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts branch July 14, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants