-
-
Notifications
You must be signed in to change notification settings - Fork 721
refactor(napi/parser, allocator): raw transfer: store buffer size and align as consts #12275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts
Jul 14, 2025
Merged
refactor(napi/parser, allocator): raw transfer: store buffer size and align as consts #12275
graphite-app
merged 1 commit into
main
from
07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts
Jul 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2025
Member
Author
Member
Author
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #12275 will not alter performanceComparing Summary
|
a3f85ed to
d009bdb
Compare
262097f to
da6d05d
Compare
da6d05d to
0636080
Compare
0636080 to
39ef911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Similar to #12268. Instead of hard-coding the size and alignment of raw transfer buffers in multiple places, codegen add these to generated files, and everywhere else import the values from those files. This is more robust.