-
-
Notifications
You must be signed in to change notification settings - Fork 724
ci(napi/oxlint): run tests with coverage profile
#12308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(napi/oxlint): run tests with coverage profile
#12308
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
cb12be6 to
5e89735
Compare
Merge activity
|
camc314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we do this for all napi packages?
The bug fixed in #12299 went unnoticed originally because we build the `napi/oxlint2` crate for tests in release mode, with debug assertions disabled. Instead, build with `--profile coverage` which enables debug assertions. It's also faster to compile.
5e89735 to
324eb2f
Compare
Not sure.
The rest of the napi packages I know nothing about! |

The bug fixed in #12299 went unnoticed originally because we build the
napi/oxlint2crate for tests in release mode, with debug assertions disabled.Instead, build with
--profile coveragewhich enables debug assertions. It's also faster to compile.