Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 15, 2025

The bug fixed in #12299 went unnoticed originally because we build the napi/oxlint2 crate for tests in release mode, with debug assertions disabled.

Instead, build with --profile coverage which enables debug assertions. It's also faster to compile.

Copy link
Member Author

overlookmotel commented Jul 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 15, 2025 22:19
@overlookmotel overlookmotel requested a review from camc314 July 15, 2025 22:19
@overlookmotel overlookmotel force-pushed the 07-15-ci_napi_oxlint_run_tests_with_coverage_profile branch from cb12be6 to 5e89735 Compare July 15, 2025 22:49
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
Copy link
Member

Boshen commented Jul 16, 2025

Merge activity

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do this for all napi packages?

The bug fixed in #12299 went unnoticed originally because we build the `napi/oxlint2` crate for tests in release mode, with debug assertions disabled.

Instead, build with `--profile coverage` which enables debug assertions. It's also faster to compile.
@graphite-app graphite-app bot force-pushed the 07-15-ci_napi_oxlint_run_tests_with_coverage_profile branch from 5e89735 to 324eb2f Compare July 16, 2025 10:40
@graphite-app graphite-app bot merged commit 324eb2f into main Jul 16, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 07-15-ci_napi_oxlint_run_tests_with_coverage_profile branch July 16, 2025 10:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
@overlookmotel
Copy link
Member Author

overlookmotel commented Jul 16, 2025

should we do this for all napi packages?

Not sure.

oxc-parser tests already take ~9 seconds to run locally, probably more in CI. It'd be ideal not to slow them down further if we can avoid it, and the compile time is pretty decent already. But maybe enabling debug assertions and -O 2 optimizations wouldn't affect runtime much? We could try it.

The rest of the napi packages I know nothing about!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants