fix(allocator): fix FixedSizeAllocator pointer maths
#12299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
CodSpeed Instrumentation Performance ReportMerging #12299 will not alter performanceComparing Summary
|
Member
Author
Merge activity
|
Fix a bug with calculating pointer to start of `Allocator` which crept in when buffer size changed in #12277.
graphite-app
bot
force-pushed
the
07-15-fix_allocator_fix_fixedsizeallocator_pointer_maths
branch
from
3662c88 to
13c5783
Compare
graphite-app
bot
deleted the
07-15-fix_allocator_fix_fixedsizeallocator_pointer_maths
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Follow-on after #12299. Document better the logic around alignment of allocator chunk pointer. It's pretty confusing, and I made a mistake here before. Clarify the logic.
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 16, 2025
The bug fixed in #12299 went unnoticed originally because we build the `napi/oxlint2` crate for tests in release mode, with debug assertions disabled. Instead, build with `--profile coverage` which enables debug assertions. It's also faster to compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug with calculating pointer to start of
Allocatorwhich crept in when buffer size changed in #12277.