Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 23, 2025

The ConstantValue would finally be used in the AST, so it can store it as Atom rather than String, which can be faster and use less memory usage.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance labels Jul 23, 2025
Copy link
Member Author

Dunqing commented Jul 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the title perf(transformer/typescript): store Atom rather than String for ConstantValue::String perf(transformer/typescript): store Atom rather than String for ConstantValue::String Jul 23, 2025
@Dunqing Dunqing force-pushed the 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string branch from 9ab93fc to 50c3a80 Compare July 23, 2025 02:35
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 23, 2025

CodSpeed Instrumentation Performance Report

Merging #12458 will not alter performance

Comparing 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string (f32c816) with main (dcb245c)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (9ff80e7) during the generation of this report, so dcb245c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Dunqing Dunqing force-pushed the 07-23-fix_transformer_typescript_incorrect_evaluation_of_templateliteral_in_enum branch from 9f82de1 to fb1a5f7 Compare July 23, 2025 02:52
@Dunqing Dunqing force-pushed the 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string branch from 50c3a80 to 3f5be6b Compare July 23, 2025 02:52
@Dunqing Dunqing marked this pull request as ready for review July 23, 2025 03:11
@Dunqing Dunqing requested a review from overlookmotel as a code owner July 23, 2025 03:11
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
@graphite-app graphite-app bot changed the base branch from 07-23-fix_transformer_typescript_incorrect_evaluation_of_templateliteral_in_enum to graphite-base/12458 July 23, 2025 04:21
@graphite-app graphite-app bot force-pushed the graphite-base/12458 branch from fb1a5f7 to dcb245c Compare July 23, 2025 04:28
@graphite-app graphite-app bot force-pushed the 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string branch from 3f5be6b to 1ea35fa Compare July 23, 2025 04:28
@graphite-app graphite-app bot changed the base branch from graphite-base/12458 to main July 23, 2025 04:29
@graphite-app graphite-app bot force-pushed the 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string branch from 1ea35fa to 53ed334 Compare July 23, 2025 04:29
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 23, 2025

Merge activity

…ConstantValue::String` (#12458)

The `ConstantValue` would finally be used in the AST, so it can store it as `Atom` rather than `String`, which can be faster and use less memory usage.
@graphite-app graphite-app bot force-pushed the 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string branch from 53ed334 to f32c816 Compare July 23, 2025 09:27
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 23, 2025

Merge activity

@graphite-app graphite-app bot merged commit f32c816 into main Jul 23, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
@graphite-app graphite-app bot deleted the 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string branch July 23, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants