perf(napi/oxlint): single Context object per rule
#12475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C-performance
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 23, 2025
graphite-app
bot
changed the base branch from
07-23-perf_napi_oxlint_recycle_more_objects
to
graphite-base/12475
Contributor
Merge activity
|
Create one `Context` object for each rule, and reuse it for each file, rather than creating a new `Context` object per rule, per file. Have not measured perf, but it seems to make sense to create less objects when possible, and it doesn't really hurt ergonomics.
graphite-app
bot
force-pushed
the
07-23-perf_napi_oxlint_single_context_object_per_rule
branch
from
d9c7a60 to
94933e8
Compare
graphite-app
bot
deleted the
07-23-perf_napi_oxlint_single_context_object_per_rule
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create one
Contextobject for each rule, and reuse it for each file, rather than creating a newContextobject per rule, per file.Have not measured perf, but it seems to make sense to create less objects when possible, and it doesn't really hurt ergonomics.