Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 23, 2025

Fix an edge case bug. Ensure loadPlugin never throws, even if user code does something wacky like throwing null or { get message() { throw new Error("ha ha ha got you!") } }.

Copy link
Member Author

overlookmotel commented Jul 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 23, 2025 14:19
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
Copy link
Contributor

camc314 commented Jul 23, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
@graphite-app graphite-app bot changed the base branch from 07-23-refactor_napi_oxlint_rename_rules_to_rulenames_ to graphite-base/12478 July 23, 2025 14:44
Fix an edge case bug. Ensure `loadPlugin` never throws, even if user code does something wacky like throwing `null` or `{ get message() { throw new Error("ha ha ha got you!") } }`.
@graphite-app graphite-app bot force-pushed the 07-23-fix_napi_oxlint_loadplugin_never_throw_error branch from 8fd523f to 954a195 Compare July 23, 2025 14:52
@github-actions github-actions bot added the A-linter Area - Linter label Jul 23, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/12478 to 07-23-refactor_napi_oxlint_rename_rules_to_rulenames_ July 23, 2025 14:53
Base automatically changed from 07-23-refactor_napi_oxlint_rename_rules_to_rulenames_ to main July 23, 2025 15:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 23, 2025

CodSpeed Instrumentation Performance Report

Merging #12478 will not alter performance

Comparing 07-23-fix_napi_oxlint_loadplugin_never_throw_error (954a195) with main (2874ec4)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (7e4959a) during the generation of this report, so 2874ec4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot merged commit 954a195 into main Jul 23, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 07-23-fix_napi_oxlint_loadplugin_never_throw_error branch July 23, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants