refactor(napi/oxlint): call lintFile with args not array
#12568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C-cleanup
This was referenced Jul 28, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Merge activity
|
Use `FnArgs` in `JsLintFileCb` to make `lintFile` JS function get called with separate arguments, rather than an array. `ThreadsafeFunction`'s API is weird!
graphite-app
bot
force-pushed
the
07-28-refactor_napi_oxlint_rename_run_to_lintfile_
branch
from
b924cb4 to
543fd53
Compare
graphite-app
bot
force-pushed
the
07-28-refactor_napi_oxlint_call_lintfile_with_args_not_array
branch
from
a559ebe to
04a1698
Compare
camc314
approved these changes
Jul 28, 2025
Base automatically changed from
07-28-refactor_napi_oxlint_rename_run_to_lintfile_
to
main
July 28, 2025 11:31
graphite-app
bot
deleted the
07-28-refactor_napi_oxlint_call_lintfile_with_args_not_array
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
FnArgsinJsLintFileCbto makelintFileJS function get called with separate arguments, rather than an array.ThreadsafeFunction's API is weird!