Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 28, 2025

Pure refactor - just renaming. The function on JS side is called lintFile. Rename run to lintFile in Rust code, to match.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 28, 2025
Copy link
Member Author

overlookmotel commented Jul 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 28, 2025 10:48
@overlookmotel overlookmotel requested a review from camc314 as a code owner July 28, 2025 10:48
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 28, 2025

CodSpeed Instrumentation Performance Report

Merging #12567 will not alter performance

Comparing 07-28-refactor_napi_oxlint_rename_run_to_lintfile_ (543fd53) with main (191a164)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from 07-28-refactor_napi_oxlint_reverse_args_of_externallinter_new_ to graphite-base/12567 July 28, 2025 10:59
@graphite-app graphite-app bot force-pushed the 07-28-refactor_napi_oxlint_rename_run_to_lintfile_ branch from 1b7a0a8 to eac6a01 Compare July 28, 2025 11:07
@graphite-app graphite-app bot force-pushed the graphite-base/12567 branch from 0fea384 to 0179c86 Compare July 28, 2025 11:07
@graphite-app graphite-app bot changed the base branch from graphite-base/12567 to main July 28, 2025 11:08
@graphite-app graphite-app bot force-pushed the 07-28-refactor_napi_oxlint_rename_run_to_lintfile_ branch from eac6a01 to 10862cc Compare July 28, 2025 11:08
@overlookmotel overlookmotel force-pushed the 07-28-refactor_napi_oxlint_rename_run_to_lintfile_ branch from 10862cc to b924cb4 Compare July 28, 2025 11:10
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 28, 2025
Copy link
Contributor

camc314 commented Jul 28, 2025

Merge activity

Pure refactor - just renaming. The function on JS side is called `lintFile`. Rename `run` to `lintFile` in Rust code, to match.
@graphite-app graphite-app bot force-pushed the 07-28-refactor_napi_oxlint_rename_run_to_lintfile_ branch from b924cb4 to 543fd53 Compare July 28, 2025 11:23
@graphite-app graphite-app bot merged commit 543fd53 into main Jul 28, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 28, 2025
@graphite-app graphite-app bot deleted the 07-28-refactor_napi_oxlint_rename_run_to_lintfile_ branch July 28, 2025 11:31
camc314 added a commit that referenced this pull request Jul 29, 2025
## [1.9.0] - 2025-07-29

### 💥 BREAKING CHANGES

- 5a7e72a semantic: [**BREAKING**] `AstNodes::program` return `&Program`
not `Option<&Program>` (#12515) (overlookmotel)

### 🚀 Features

- 3489ce0 linter: Add `typescript-eslint/explicit-module-boundary-types`
(#12402) (Don Isaac)

### 🐛 Bug Fixes

- 0fd3e87 linter: Default options for `eslint/yoda` (#12540) (Sysix)
- 724776f linter: Default options for `unicorn/switch-case-braces`
(#12539) (Sysix)
- fda45ea linter/promise/prefer-await-to-callbacks: False positive for
`addEventListener` (#12537) (Copilot)
- 1a710e3 linter/array-type: Fix more false negatives (#12501) (camc314)
- 2b5bf98 linter: Consistent-function-scoping false positive with
hoisted var declarations (#12523) (camc314)
- cc19c8b vscode: Fix statusbar icon order (#12544) (Christian Fehmer)
- 209d006 linter: Parse vue lang attribute without quotes (#12517)
(Sysix)
- 85a34ce linter/array-type: False negative with arrays in generic args
(#12500) (camc314)
- 98c1fbb linter/require-await: Improve async keyword detection in
get_delete_span function (#12494) (camc314)
- 7c75dba linter/require-await: Improve span calculation for object
properties (#12490) (camc314)
- 2b261cf linter/exhaustive-deps: False positive in exhaustive deps
(#12471) (camc314)

### 🚜 Refactor

- a696227 linter: Remove AstKind for SimpleAssignmentTarget (#12401)
(Tyler Earls)
- 7af38e1 napi/oxlint: Simplify `ExternalLinterLintFileCb` type (#12572)
(overlookmotel)
- 543fd53 napi/oxlint: Rename `run` to `lintFile` (#12567)
(overlookmotel)
- 0179c86 napi/oxlint: Reverse args of `ExternalLinter::new` (#12566)
(overlookmotel)
- 491c401 linter: Remove `#[must_use]` from `LintService::with_*`
methods (#12560) (overlookmotel)
- d44b0ac linter: Remove `Runner` trait (#12559) (overlookmotel)
- bea652f linter: Add `vue` and `regex` to `BuiltinLintPlugins` (#12542)
(Sysix)
- aa9dd21 linter/no-eval: Get source type from `Semantic` (#12514)
(overlookmotel)
- 5c33fc7 diagnostics: Implement `Eq` and `Ord` for `InfoPosition`
(#12505) (overlookmotel)
- 8c8c8bc napi/oxlint: Diagnostics communicate which rule via rule
index, not rule ID (#12482) (overlookmotel)
- e2d9b4d fixer: Add Debug trait to PossibleFixes and Message structs
(#12493) (camc314)
- f0b1f0d napi/oxlint, napi/parser: Remove source length from
`RawTransferMetadata` (#12483) (overlookmotel)
- 7e4959a napi/oxlint: Rename `rules` to `ruleNames` (#12477)
(overlookmotel)
- 7a0da04 diagnostics: Remove Option wrapper from MPSC channel and
sender field (#12467) (camc314)

### 🧪 Testing

- 56468c7 linter/no-unused-private-class-members: Add more test cases
(#12569) (camc314)
- 191a164 linter/no-unused-private-class-members: Add more test cases
(#12563) (camc314)
- d31adcf linter: Improve sorting diagnostics (#12504) (overlookmotel)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants