test(linter): improve sorting diagnostics #12504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-cli
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
This was prompted by #12472 (comment). Do we maybe want to add |
camc314
reviewed
Jul 24, 2025
camc314
approved these changes
Jul 24, 2025
Contributor
Merge activity
|
Improve (I think) ordering of diagnostic in test snapshots. 1. Sort by filename first, then position. I think this was probably the original intention. 2. Include start column and end line+column in sort, for more deterministic order. 3. Use `sort_by_cached_key`. `Info::new` creates up to 3 `String` allocations, so preferable to cache the result of the closure, to avoid making those allocations repeatedly. `sort_by_key` will likely call the closure many times for each element. If I've understood right, this reporter is only used in tests, so this PR makes no difference to users.
graphite-app
bot
force-pushed
the
07-24-test_linter_improve_sorting_diagnostics
branch
from
412b045 to
d31adcf
Compare
graphite-app
bot
deleted the
07-24-test_linter_improve_sorting_diagnostics
branch
camc314
added a commit
that referenced
this pull request
Jul 29, 2025
## [1.9.0] - 2025-07-29 ### 💥 BREAKING CHANGES - 5a7e72a semantic: [**BREAKING**] `AstNodes::program` return `&Program` not `Option<&Program>` (#12515) (overlookmotel) ### 🚀 Features - 3489ce0 linter: Add `typescript-eslint/explicit-module-boundary-types` (#12402) (Don Isaac) ### 🐛 Bug Fixes - 0fd3e87 linter: Default options for `eslint/yoda` (#12540) (Sysix) - 724776f linter: Default options for `unicorn/switch-case-braces` (#12539) (Sysix) - fda45ea linter/promise/prefer-await-to-callbacks: False positive for `addEventListener` (#12537) (Copilot) - 1a710e3 linter/array-type: Fix more false negatives (#12501) (camc314) - 2b5bf98 linter: Consistent-function-scoping false positive with hoisted var declarations (#12523) (camc314) - cc19c8b vscode: Fix statusbar icon order (#12544) (Christian Fehmer) - 209d006 linter: Parse vue lang attribute without quotes (#12517) (Sysix) - 85a34ce linter/array-type: False negative with arrays in generic args (#12500) (camc314) - 98c1fbb linter/require-await: Improve async keyword detection in get_delete_span function (#12494) (camc314) - 7c75dba linter/require-await: Improve span calculation for object properties (#12490) (camc314) - 2b261cf linter/exhaustive-deps: False positive in exhaustive deps (#12471) (camc314) ### 🚜 Refactor - a696227 linter: Remove AstKind for SimpleAssignmentTarget (#12401) (Tyler Earls) - 7af38e1 napi/oxlint: Simplify `ExternalLinterLintFileCb` type (#12572) (overlookmotel) - 543fd53 napi/oxlint: Rename `run` to `lintFile` (#12567) (overlookmotel) - 0179c86 napi/oxlint: Reverse args of `ExternalLinter::new` (#12566) (overlookmotel) - 491c401 linter: Remove `#[must_use]` from `LintService::with_*` methods (#12560) (overlookmotel) - d44b0ac linter: Remove `Runner` trait (#12559) (overlookmotel) - bea652f linter: Add `vue` and `regex` to `BuiltinLintPlugins` (#12542) (Sysix) - aa9dd21 linter/no-eval: Get source type from `Semantic` (#12514) (overlookmotel) - 5c33fc7 diagnostics: Implement `Eq` and `Ord` for `InfoPosition` (#12505) (overlookmotel) - 8c8c8bc napi/oxlint: Diagnostics communicate which rule via rule index, not rule ID (#12482) (overlookmotel) - e2d9b4d fixer: Add Debug trait to PossibleFixes and Message structs (#12493) (camc314) - f0b1f0d napi/oxlint, napi/parser: Remove source length from `RawTransferMetadata` (#12483) (overlookmotel) - 7e4959a napi/oxlint: Rename `rules` to `ruleNames` (#12477) (overlookmotel) - 7a0da04 diagnostics: Remove Option wrapper from MPSC channel and sender field (#12467) (camc314) ### 🧪 Testing - 56468c7 linter/no-unused-private-class-members: Add more test cases (#12569) (camc314) - 191a164 linter/no-unused-private-class-members: Add more test cases (#12563) (camc314) - d31adcf linter: Improve sorting diagnostics (#12504) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve (I think) ordering of diagnostic in test snapshots.
sort_by_cached_key.Info::newcreates up to 3Stringallocations, so preferable to cache the result of the closure, to avoid making those allocations repeatedly.sort_by_keywill likely call the closure many times for each element.If I've understood right, this reporter is only used in tests, so this PR makes no difference to users.