perf(diagnostics): Info::new trim string in place

[overlookmotel]

Small optimization. Info::new trim message String in place, rather than creating a new String and dropping the old one.

Why doesn't Rust have String::trim_in_place and String::trim_start_matches_in_place?

[overlookmotel]

• perf(diagnostics): Info::new trim string in place #12506 👈 (View in Graphite)
• refactor(diagnostics): implement Eq and Ord for InfoPosition #12505
• test(linter): improve sorting diagnostics #12504
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12506 will not alter performance

_{Comparing 07-24-perf_diagnostics_info_new_trim_string_in_place (ce5d074) with main (85a34ce)¹}

Summary

✅ 34 untouched benchmarks

Footnotes

1. No successful run was found on 07-24-refactor_diagnostics_implement_eq_and_ord_for_infoposition_ (5c33fc7) during the generation of this report, so main (85a34ce) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[camc314]

Merge activity

• Jul 24, 5:34 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 24, 5:39 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Jul 24, 5:48 PM UTC: Merged by the Graphite merge queue.