-
-
Notifications
You must be signed in to change notification settings - Fork 727
fix(formatter): is_long_curried_call cannot handle cases where the parent node is not a CallExpression #12580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
07-28-fix_formatter_is_long_curried_call_cannot_handle_cases_where_the_parent_node_is_not_a_callexpression
Jul 30, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2025
Member
Author
CodSpeed Instrumentation Performance ReportMerging #12580 will not alter performanceComparing Summary
Footnotes |
54a909e to
8a4e036
Compare
6d5f35a to
4ec1196
Compare
This was referenced Jul 29, 2025
Contributor
Merge activity
|
8a4e036 to
90689e8
Compare
…rent node is not a CallExpression (#12580) The previous implementation only considers the situation that the parent node is a CallExpression, but this turns out to be incorrect. We have to deal with some cases where the current node is a `CallExpression` rather than the parent node.
90689e8 to
bae4de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

The previous implementation only considers the situation that the parent node is a CallExpression, but this turns out to be incorrect. We have to deal with some cases where the current node is a
CallExpressionrather than the parent node.