Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 28, 2025

The previous implementation only considers the situation that the parent node is a CallExpression, but this turns out to be incorrect. We have to deal with some cases where the current node is a CallExpression rather than the parent node.

Copy link
Member Author

Dunqing commented Jul 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 28, 2025

CodSpeed Instrumentation Performance Report

Merging #12580 will not alter performance

Comparing 07-28-fix_formatter_is_long_curried_call_cannot_handle_cases_where_the_parent_node_is_not_a_callexpression (bae4de3) with main (516eaf0)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (9bf6ed5) during the generation of this report, so 516eaf0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Dunqing Dunqing changed the base branch from 07-25-feat_formatter_support_printing_member_chain to graphite-base/12580 July 29, 2025 09:06
@Dunqing Dunqing force-pushed the 07-28-fix_formatter_is_long_curried_call_cannot_handle_cases_where_the_parent_node_is_not_a_callexpression branch from 54a909e to 8a4e036 Compare July 29, 2025 10:18
@Dunqing Dunqing force-pushed the graphite-base/12580 branch from 6d5f35a to 4ec1196 Compare July 29, 2025 10:18
@Dunqing Dunqing changed the base branch from graphite-base/12580 to 07-25-feat_formatter_support_printing_member_chain July 29, 2025 10:18
@Dunqing Dunqing marked this pull request as ready for review July 30, 2025 02:42
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 30, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 30, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 30, 2025
@Dunqing Dunqing changed the base branch from 07-25-feat_formatter_support_printing_member_chain to graphite-base/12580 July 30, 2025 03:41
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 30, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/12580 to main July 30, 2025 04:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 30, 2025
@Dunqing Dunqing force-pushed the 07-28-fix_formatter_is_long_curried_call_cannot_handle_cases_where_the_parent_node_is_not_a_callexpression branch from 8a4e036 to 90689e8 Compare July 30, 2025 06:06
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 30, 2025
…rent node is not a CallExpression (#12580)

The previous implementation only considers the situation that the parent node is a CallExpression, but this turns out to be incorrect. We have to deal with some cases where the current node is a `CallExpression` rather than the parent node.
@graphite-app graphite-app bot force-pushed the 07-28-fix_formatter_is_long_curried_call_cannot_handle_cases_where_the_parent_node_is_not_a_callexpression branch from 90689e8 to bae4de3 Compare July 30, 2025 06:31
@graphite-app graphite-app bot merged commit bae4de3 into main Jul 30, 2025
24 of 25 checks passed
@graphite-app graphite-app bot deleted the 07-28-fix_formatter_is_long_curried_call_cannot_handle_cases_where_the_parent_node_is_not_a_callexpression branch July 30, 2025 06:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants