Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 29, 2025

Previously, we didn't support MemberChain yet, so we missed this check. Now we have added.

Copy link
Member Author

Dunqing commented Jul 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 29, 2025

CodSpeed Instrumentation Performance Report

Merging #12587 will not alter performance

Comparing 07-29-fix_formatter_incorrect_check_for_assignment-like_node_if_the_right-hand_side_is_a_member_chain (cf78793) with 07-29-feat_formatter_check_chainexpression_for_simpleargument (78c37f0)

Summary

✅ 34 untouched benchmarks

@Dunqing Dunqing force-pushed the 07-29-fix_formatter_incorrect_check_for_assignment-like_node_if_the_right-hand_side_is_a_member_chain branch from c36a31e to c4ca44f Compare July 30, 2025 01:53
@Dunqing Dunqing marked this pull request as ready for review July 30, 2025 02:53
@Dunqing Dunqing force-pushed the 07-29-fix_formatter_incorrect_check_for_assignment-like_node_if_the_right-hand_side_is_a_member_chain branch from c4ca44f to fa1b7d3 Compare July 30, 2025 03:03
@Dunqing Dunqing force-pushed the 07-29-feat_formatter_check_chainexpression_for_simpleargument branch from 95eb1b6 to 37093ee Compare July 30, 2025 03:03
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 30, 2025
Copy link
Member

Boshen commented Jul 30, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 30, 2025
@Dunqing Dunqing force-pushed the 07-29-fix_formatter_incorrect_check_for_assignment-like_node_if_the_right-hand_side_is_a_member_chain branch from fa1b7d3 to 3a06f69 Compare July 30, 2025 06:06
@Dunqing Dunqing force-pushed the 07-29-feat_formatter_check_chainexpression_for_simpleargument branch from 37093ee to 2a9afea Compare July 30, 2025 06:06
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 30, 2025
…-hand side is a member chain (#12587)

Previously, we didn't support MemberChain yet, so we missed this check. Now we have added.
@graphite-app graphite-app bot force-pushed the 07-29-feat_formatter_check_chainexpression_for_simpleargument branch from 2a9afea to 78c37f0 Compare July 30, 2025 06:32
@graphite-app graphite-app bot force-pushed the 07-29-fix_formatter_incorrect_check_for_assignment-like_node_if_the_right-hand_side_is_a_member_chain branch from 3a06f69 to cf78793 Compare July 30, 2025 06:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 30, 2025
Base automatically changed from 07-29-feat_formatter_check_chainexpression_for_simpleargument to main July 30, 2025 06:41
@graphite-app graphite-app bot merged commit cf78793 into main Jul 30, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 07-29-fix_formatter_incorrect_check_for_assignment-like_node_if_the_right-hand_side_is_a_member_chain branch July 30, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants