-
-
Notifications
You must be signed in to change notification settings - Fork 727
fix(formatter): incorrect check for assignment-like node if the right-hand side is a member chain #12587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
07-29-fix_formatter_incorrect_check_for_assignment-like_node_if_the_right-hand_side_is_a_member_chain
Jul 30, 2025
Merged
+60
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2025
Member
Author
This was referenced Jul 29, 2025
CodSpeed Instrumentation Performance ReportMerging #12587 will not alter performanceComparing Summary
|
c36a31e to
c4ca44f
Compare
c4ca44f to
fa1b7d3
Compare
95eb1b6 to
37093ee
Compare
Member
Merge activity
|
fa1b7d3 to
3a06f69
Compare
37093ee to
2a9afea
Compare
…-hand side is a member chain (#12587) Previously, we didn't support MemberChain yet, so we missed this check. Now we have added.
2a9afea to
78c37f0
Compare
3a06f69 to
cf78793
Compare
Base automatically changed from
07-29-feat_formatter_check_chainexpression_for_simpleargument
to
main
July 30, 2025 06:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Previously, we didn't support MemberChain yet, so we missed this check. Now we have added.