perf(semantic): remove function stack #12676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-semantic
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12676 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
07-31-perf_semantic_faster_function_stack
branch
from
8428610 to
71f5e57
Compare
overlookmotel
force-pushed
the
07-31-perf_semantic_faster_function_stack
branch
from
71f5e57 to
6e07abd
Compare
overlookmotel
changed the title
Member
Merge activity
|
Only purpose of `function_stack` in `SemanticBuilder` is to track the current function, in order to set `NodeFlags::HasYield` on it if it contains `yield`. #12630 moved enter and exit logic into `visit_function`. So now we don't need a `Stack` to track the current function, we can use vars on the actual stack. Also, it's unnecessary to update current function when entering/exiting arrow functions, as they can't contain `yield`.
graphite-app
bot
force-pushed
the
07-31-perf_semantic_faster_function_stack
branch
from
6e07abd to
2ccf725
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
Follow-on after #12676. Fix a typo I introduced in that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only purpose of
function_stackinSemanticBuilderis to track the current function, in order to setNodeFlags::HasYieldon it if it containsyield.#12630 moved enter and exit logic into
visit_function. So now we don't need aStackto track the current function, we can use vars on the actual stack.Also, it's unnecessary to update current function when entering/exiting arrow functions, as they can't contain
yield.