Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 1, 2025

Follow-on after #12676. Fix a typo I introduced in that PR.

@github-actions github-actions bot added A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 1, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review August 1, 2025 10:12
@overlookmotel overlookmotel requested a review from Dunqing as a code owner August 1, 2025 10:12
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 1, 2025
@overlookmotel overlookmotel removed the request for review from Dunqing August 1, 2025 10:12
Copy link
Member Author

overlookmotel commented Aug 1, 2025

Merge activity

@Boshen
Copy link
Member

Boshen commented Aug 1, 2025

Why is this not done by AI?

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 1, 2025

CodSpeed Instrumentation Performance Report

Merging #12714 will not alter performance

Comparing 08-01-refactor_semantic_fix_typo_in_comment (090cf88) with main (737003e)

Summary

✅ 34 untouched benchmarks

Follow-on after #12676. Fix a typo I introduced in that PR.
@graphite-app graphite-app bot force-pushed the 08-01-refactor_semantic_fix_typo_in_comment branch from 993d0a0 to 090cf88 Compare August 1, 2025 10:23
@overlookmotel
Copy link
Member Author

overlookmotel commented Aug 1, 2025

Why is this not done by AI?

Not sure. Usually PR review bot catches these kinds of grammatical errors. Don't know why it didn't in this case.

@graphite-app graphite-app bot merged commit 090cf88 into main Aug 1, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-01-refactor_semantic_fix_typo_in_comment branch August 1, 2025 10:31
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants