feat(allocator): add data_end_ptr and set_cursor_ptr methods to Allocator
#13134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13134 will not alter performanceComparing Summary
Footnotes |
overlookmotel
force-pushed
the
08-15-feat_allocator_add_data_end_ptr_and_set_cursor_ptr_methods_to_allocator_
branch
from
11cb71b to
ab90104
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
overlookmotel
force-pushed
the
08-15-feat_allocator_add_data_end_ptr_and_set_cursor_ptr_methods_to_allocator_
branch
from
ab90104 to
81db99e
Compare
camc314
approved these changes
Aug 16, 2025
graphite-app
bot
changed the base branch from
08-15-refactor_napi_parser_move_creating_js_buffer_into_separate_function
to
graphite-base/13134
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds two new unsafe methods to the Allocator struct to provide lower-level memory management capabilities. The methods allow direct manipulation of the allocator's internal pointers and are only available when the from_raw_parts cargo feature is enabled.
- Adds
set_cursor_ptrmethod for manually setting the cursor pointer within the current chunk - Adds
data_end_ptrmethod to get a pointer to the end of the data region in the current chunk
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
graphite-app
bot
force-pushed
the
graphite-base/13134
branch
from
3a1001c to
c8b97de
Compare
graphite-app
bot
force-pushed
the
08-15-feat_allocator_add_data_end_ptr_and_set_cursor_ptr_methods_to_allocator_
branch
from
81db99e to
7e6db63
Compare
graphite-app
bot
force-pushed
the
08-15-feat_allocator_add_data_end_ptr_and_set_cursor_ptr_methods_to_allocator_
branch
from
7e6db63 to
5bd7d9e
Compare
Member
Author
Merge activity
|
…Allocator` (#13134) Add 2 more unsafe methods to `Allocator` to meddle with its internals. These methods are only present when `from_raw_parts` cargo feature is enabled. These methods are used in a later PR in this stack, to write flags for which JS threads an `Allocator` is shared with into the `Allocator`s memory.
graphite-app
bot
force-pushed
the
08-15-feat_allocator_add_data_end_ptr_and_set_cursor_ptr_methods_to_allocator_
branch
from
5bd7d9e to
7cf6186
Compare
graphite-app
bot
deleted the
08-15-feat_allocator_add_data_end_ptr_and_set_cursor_ptr_methods_to_allocator_
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 17, 2025
…thods (#13139) Correct safety comments on unsafe methods of `Allocator`, as suggested by AI in #13134 (review). Also expand the safety comments for `Allocator::set_data_ptr`, and add comments on how its invariants are upheld at call sites. Also correct typos and improve comment formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 more unsafe methods to
Allocatorto meddle with its internals. These methods are only present whenfrom_raw_partscargo feature is enabled.These methods are used in a later PR in this stack, to write flags for which JS threads an
Allocatoris shared with into theAllocators memory.