refactor(allocator, linter): add ref counter to FixedSizeAllocator
#13135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 15, 2025
CodSpeed Instrumentation Performance ReportMerging #13135 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
08-15-feat_allocator_add_data_end_ptr_and_set_cursor_ptr_methods_to_allocator_
branch
from
11cb71b to
ab90104
Compare
overlookmotel
force-pushed
the
08-14-refactor_allocator_linter_add_ref_counter_to_fixedsizeallocator_
branch
2 times, most recently
from
95015b0 to
fce48b1
Compare
overlookmotel
force-pushed
the
08-15-feat_allocator_add_data_end_ptr_and_set_cursor_ptr_methods_to_allocator_
branch
from
ab90104 to
81db99e
Compare
graphite-app
bot
force-pushed
the
08-15-feat_allocator_add_data_end_ptr_and_set_cursor_ptr_methods_to_allocator_
branch
2 times, most recently
from
7e6db63 to
5bd7d9e
Compare
graphite-app
bot
force-pushed
the
08-14-refactor_allocator_linter_add_ref_counter_to_fixedsizeallocator_
branch
from
fce48b1 to
23f238c
Compare
graphite-app
bot
changed the base branch from
08-15-feat_allocator_add_data_end_ptr_and_set_cursor_ptr_methods_to_allocator_
to
graphite-base/13135
graphite-app
bot
force-pushed
the
08-14-refactor_allocator_linter_add_ref_counter_to_fixedsizeallocator_
branch
from
23f238c to
5f31d1c
Compare
graphite-app
bot
force-pushed
the
graphite-base/13135
branch
from
5bd7d9e to
7cf6186
Compare
graphite-app
bot
force-pushed
the
08-14-refactor_allocator_linter_add_ref_counter_to_fixedsizeallocator_
branch
from
5f31d1c to
6121c3e
Compare
overlookmotel
force-pushed
the
08-14-refactor_allocator_linter_add_ref_counter_to_fixedsizeallocator_
branch
from
6121c3e to
802044e
Compare
overlookmotel
changed the base branch from
graphite-base/13135
to
08-16-docs_allocator_correct_and_expand_safety_comments_on_allocator_methods
graphite-app
bot
changed the base branch from
08-16-docs_allocator_correct_and_expand_safety_comments_on_allocator_methods
to
graphite-base/13135
graphite-app
bot
force-pushed
the
graphite-base/13135
branch
from
1900b28 to
33ce529
Compare
graphite-app
bot
force-pushed
the
08-14-refactor_allocator_linter_add_ref_counter_to_fixedsizeallocator_
branch
from
802044e to
7358a6c
Compare
graphite-app
bot
force-pushed
the
08-14-refactor_allocator_linter_add_ref_counter_to_fixedsizeallocator_
branch
from
7358a6c to
694f870
Compare
overlookmotel
force-pushed
the
08-14-refactor_allocator_linter_add_ref_counter_to_fixedsizeallocator_
branch
from
694f870 to
0777540
Compare
overlookmotel
force-pushed
the
08-14-refactor_allocator_linter_add_ref_counter_to_fixedsizeallocator_
branch
from
0777540 to
deacd22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linter previously tracked whether an
Allocator's memory is shared between Rust and JS with anAtomicBoolflag.Replace this flag with an
AtomicU32reference counter. This prepares the way for sharing the memory owned by aFixedSizeAllocatorwith multiple JS threads, and tracking when it's been released by all JS threads, and Rust.