feat(semantic): add ability to lookup if AST contains any node kinds #13137

camchenry · 2025-08-16T03:31:03Z

I decided to revive this stack: #12227 and merge all of the changes into one PR for slightly easier review and changes.

This PR adds a new AstTypesBitset struct which is a set of bits that has a fixed size known at compile time and can be used to store AST types as a set. The aim of this structure is to making checks like "does this file have a for statement?" possible to answer without doing any additional iterations over the AST.

camchenry · 2025-08-16T03:31:20Z

perf(linter): skip rules that do not have any relevant node types #13138 : 2 dependent PRs (#13287 , #13573 )
feat(semantic): add ability to lookup if AST contains any node kinds #13137 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-08-16T03:36:00Z

CodSpeed Instrumentation Performance Report

Merging #13137 will not alter performance

_{Comparing 08-15-feat_semantic_add_ability_to_lookup_if_ast_contains_any_node_kinds (f00adbe) with main (5648b31)}

Summary

✅ 4 untouched benchmarks
⁉️ 33 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⁉️	`codegen[RadixUIAdoptionSection.jsx]`	120.1 µs	N/A	N/A
⁉️	`codegen[binder.ts]`	4 ms	N/A	N/A
⁉️	`codegen[cal.com.tsx]`	34.4 ms	N/A	N/A
⁉️	`codegen[react.development.js]`	1.9 ms	N/A	N/A
⁉️	`formatter[RadixUIAdoptionSection.jsx]`	570.9 µs	N/A	N/A
⁉️	`formatter[binder.ts]`	22.6 ms	N/A	N/A
⁉️	`formatter[cal.com.tsx]`	206.9 ms	N/A	N/A
⁉️	`formatter[react.development.js]`	11.5 ms	N/A	N/A
⁉️	`lexer[RadixUIAdoptionSection.jsx]`	20.1 µs	N/A	N/A
⁉️	`lexer[binder.ts]`	870.5 µs	N/A	N/A
⁉️	`lexer[cal.com.tsx]`	5.3 ms	N/A	N/A
⁉️	`lexer[react.development.js]`	356.9 µs	N/A	N/A
⁉️	`linter[RadixUIAdoptionSection.jsx]`	2.6 ms	N/A	N/A
⁉️	`linter[binder.ts]`	148 ms	N/A	N/A
⁉️	`linter[cal.com.tsx]`	1.2 s	N/A	N/A
⁉️	`linter[react.development.js]`	52.6 ms	N/A	N/A
⁉️	`mangler[RadixUIAdoptionSection.jsx]`	11.6 µs	N/A	N/A
⁉️	`mangler[binder.ts]`	733.3 µs	N/A	N/A
⁉️	`mangler[cal.com.tsx]`	2.8 ms	N/A	N/A
⁉️	`mangler[react.development.js]`	259.1 µs	N/A	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

tasks/ast_tools/src/generators/ast_kind.rs

crates/oxc_semantic/src/ast_types_bitset.rs

crates/oxc_semantic/src/node.rs

camc314

this looks really nice, should definetly help optimizing linter perf

Copilot

Pull Request Overview

This PR adds a new AstTypesBitset data structure to efficiently track which AST node types are present in a semantic analysis tree. The bitset enables fast "contains" queries without iterating through the entire AST.

Introduces AstTypesBitset struct with bitwise operations for AST type tracking
Adds AST_TYPE_MAX constant for compile-time bitset sizing
Integrates bitset into AstNodes with automatic population during node creation

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File	Description
tasks/ast_tools/src/generators/ast_kind.rs	Generates `AST_TYPE_MAX` constant for bitset sizing
crates/oxc_semantic/src/node.rs	Integrates bitset into `AstNodes` and adds query methods
crates/oxc_semantic/src/lib.rs	Adds new module declaration
crates/oxc_semantic/src/ast_types_bitset.rs	Implements the core bitset data structure and operations

Comments suppressed due to low confidence (1)

crates/oxc_semantic/src/ast_types_bitset.rs:1

The contains method can short-circuit early when a mismatch is found. Consider returning false immediately when mismatch != 0 instead of accumulating all mismatches.

use oxc_ast::{AstType, ast_kind::AST_TYPE_MAX};

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_semantic/src/node.rs

crates/oxc_semantic/src/ast_types_bitset.rs

overlookmotel

Feel free to correct the comment in a later PR, rather than having to restack this whole stack.

crates/oxc_semantic/src/ast_types_bitset.rs

overlookmotel · 2025-09-07T07:20:08Z

Merge activity

Sep 7, 7:20 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 7, 7:20 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
Sep 7, 7:26 AM UTC: Merged by the Graphite merge queue.

…13137) I decided to revive this stack: #12227 and merge all of the changes into one PR for slightly easier review and changes. This PR adds a new `AstTypesBitset` struct which is a set of bits that has a fixed size known at compile time and can be used to store AST types as a set. The aim of this structure is to making checks like "does this file have a for statement?" possible to answer without doing any additional iterations over the AST.

Follow-on after #13137. Correct a comment, as per #13137 (comment).

…13137) I decided to revive this stack: #12227 and merge all of the changes into one PR for slightly easier review and changes. This PR adds a new `AstTypesBitset` struct which is a set of bits that has a fixed size known at compile time and can be used to store AST types as a set. The aim of this structure is to making checks like "does this file have a for statement?" possible to answer without doing any additional iterations over the AST.

Follow-on after #13137. Correct a comment, as per #13137 (comment).

…le (#13595) Follow-on after #13137. That PR added methods to `AstNodes`, and doc comments include examples. Make those examples into proper runnable doctests, and fix them (`AstType::ExportDeclaration` doesn't exist).

…evant nodes (#14457) Finally making use of the optimizations enabled by #13137. We can use the AST type bitset for each file to skip rules that only care about specific node types if the file has none of those node types.

github-actions bot added A-semantic Area - Semantic A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Aug 16, 2025

This was referenced Aug 16, 2025

feat(semantic): add methods to check if AST contains any/all node types #12227

Closed

feat(semantic): add set of AstType that exist in AST #12226

Closed

feat(ast): compute max value that can be mapped to AstType #12225

Closed

camchenry force-pushed the 08-15-feat_semantic_add_ability_to_lookup_if_ast_contains_any_node_kinds branch from 55ccbf2 to 8e31c70 Compare August 16, 2025 04:22

camchenry mentioned this pull request Aug 16, 2025

perf(linter): skip rules that do not have any relevant node types #13138

Merged

overlookmotel reviewed Aug 16, 2025

View reviewed changes

camc314 reviewed Aug 16, 2025

View reviewed changes

camchenry force-pushed the 08-15-feat_semantic_add_ability_to_lookup_if_ast_contains_any_node_kinds branch 5 times, most recently from 4649cd4 to af12449 Compare August 23, 2025 17:48

camchenry force-pushed the 08-15-feat_semantic_add_ability_to_lookup_if_ast_contains_any_node_kinds branch from af12449 to f6b3a21 Compare August 24, 2025 04:07

camchenry marked this pull request as ready for review August 25, 2025 03:12

Copilot AI review requested due to automatic review settings August 25, 2025 03:12

camchenry requested a review from Dunqing as a code owner August 25, 2025 03:12

camchenry force-pushed the 08-15-feat_semantic_add_ability_to_lookup_if_ast_contains_any_node_kinds branch from f6b3a21 to 99956af Compare August 25, 2025 04:03

camchenry mentioned this pull request Aug 25, 2025

perf(linter): generate node type info for lint rules with let..else #13287

Closed

This comment was marked as outdated.

Sign in to view

camc314 requested a review from Copilot August 25, 2025 12:26

Copilot AI reviewed Aug 25, 2025

View reviewed changes

crates/oxc_semantic/src/node.rs Outdated Show resolved Hide resolved

crates/oxc_semantic/src/ast_types_bitset.rs Show resolved Hide resolved

camchenry mentioned this pull request Aug 25, 2025

perf(linter): filter out rules which have no relevant node types in file #13297

Closed

camchenry force-pushed the 08-15-feat_semantic_add_ability_to_lookup_if_ast_contains_any_node_kinds branch 2 times, most recently from 589a962 to f03068b Compare August 26, 2025 01:45

camc314 approved these changes Aug 26, 2025

View reviewed changes

overlookmotel approved these changes Aug 26, 2025

View reviewed changes

crates/oxc_semantic/src/ast_types_bitset.rs Show resolved Hide resolved

camchenry force-pushed the 08-15-feat_semantic_add_ability_to_lookup_if_ast_contains_any_node_kinds branch 4 times, most recently from 6948775 to 9c9a1c9 Compare September 3, 2025 21:31

overlookmotel approved these changes Sep 7, 2025

View reviewed changes

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 7, 2025

graphite-app bot force-pushed the 08-15-feat_semantic_add_ability_to_lookup_if_ast_contains_any_node_kinds branch from 9c9a1c9 to f00adbe Compare September 7, 2025 07:20

graphite-app bot merged commit f00adbe into main Sep 7, 2025
17 of 25 checks passed

graphite-app bot deleted the 08-15-feat_semantic_add_ability_to_lookup_if_ast_contains_any_node_kinds branch September 7, 2025 07:26

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 7, 2025

graphite-app bot pushed a commit that referenced this pull request Sep 7, 2025

fix(semantic): correct comment on AstTypesBitset (#13572)

d6b2e57

Follow-on after #13137. Correct a comment, as per #13137 (comment).

overlookmotel mentioned this pull request Sep 7, 2025

perf(linter): store rules by AST type in a boxed array #13578

Merged

oxc-bot mentioned this pull request Sep 8, 2025

release(crates): v0.87.0 #13587

Merged

Copilot AI pushed a commit that referenced this pull request Sep 8, 2025

fix(semantic): correct comment on AstTypesBitset (#13572)

49ae989

Follow-on after #13137. Correct a comment, as per #13137 (comment).

overlookmotel mentioned this pull request Sep 8, 2025

docs(semantic): make doc tests for AstNode::contains_any etc runnable #13595

Merged

camchenry mentioned this pull request Oct 9, 2025

perf(linter): skip running node-specific rule if file contains no relevant nodes #14457

Merged

Uh oh!

feat(semantic): add ability to lookup if AST contains any node kinds #13137

feat(semantic): add ability to lookup if AST contains any node kinds #13137

Uh oh!

Conversation

camchenry commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camchenry commented Aug 16, 2025 • edited by overlookmotel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13137 will not alter performance

Summary

Benchmarks breakdown

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

overlookmotel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

overlookmotel commented Sep 7, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camchenry commented Aug 16, 2025 •

edited

Loading

camchenry commented Aug 16, 2025 •

edited by overlookmotel

Loading

codspeed-hq bot commented Aug 16, 2025 •

edited

Loading

overlookmotel commented Sep 7, 2025 •

edited by graphite-app bot

Loading