build(napi/oxlint): simplify build script #13695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 11, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
overlookmotel
force-pushed
the
09-11-build_napi_oxlint_simplify_build_script
branch
from
2735f01 to
16ae6bb
Compare
This was referenced Sep 11, 2025
camc314
approved these changes
Sep 12, 2025
graphite-app
bot
changed the base branch from
09-11-refactor_napi_oxlint_rename_napi_oxlint2_to_napi_oxlint_
to
graphite-base/13695
Contributor
Merge activity
|
overlookmotel
force-pushed
the
09-11-build_napi_oxlint_simplify_build_script
branch
from
16ae6bb to
80f3ca5
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the build script for napi/oxlint to simplify and streamline the code while maintaining the same functionality. The script now uses more concise patterns and eliminates redundant code.
Key changes:
- Simplified file copying logic with a reusable
copyFilehelper function - Replaced explicit file existence checks with automatic directory creation
- Used dynamic file discovery for
.nodefiles instead of hardcoded list
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pure refactor. Simplify the build script for `napi/oxlint`. Does not alter the files which end up in `dist` directory.
graphite-app
bot
force-pushed
the
09-11-build_napi_oxlint_simplify_build_script
branch
from
80f3ca5 to
d13b5b2
Compare
graphite-app
bot
deleted the
09-11-build_napi_oxlint_simplify_build_script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Simplify the build script for
napi/oxlint. Does not alter the files which end up indistdirectory.