build(napi/oxlint): do not extern constants.mjs
#13696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 11, 2025
overlookmotel
force-pushed
the
09-11-build_napi_oxlint_do_not_extern_constants.mjs_
branch
from
0d09c13 to
2f242a6
Compare
overlookmotel
force-pushed
the
09-11-build_napi_oxlint_simplify_build_script
branch
from
2735f01 to
16ae6bb
Compare
This was referenced Sep 11, 2025
camc314
approved these changes
Sep 12, 2025
Contributor
Merge activity
|
overlookmotel
changed the base branch from
09-11-build_napi_oxlint_simplify_build_script
to
graphite-base/13696
overlookmotel
force-pushed
the
graphite-base/13696
branch
from
16ae6bb to
80f3ca5
Compare
overlookmotel
force-pushed
the
09-11-build_napi_oxlint_do_not_extern_constants.mjs_
branch
from
2f242a6 to
df3ea39
Compare
overlookmotel
changed the base branch from
graphite-base/13696
to
09-11-build_napi_oxlint_simplify_build_script
graphite-app
bot
force-pushed
the
09-11-build_napi_oxlint_simplify_build_script
branch
from
80f3ca5 to
d13b5b2
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
Surprisingly, TSDown inlines the constants from `constants.mjs` into the bundled code, regardless of whether the file is listed as `external` in TSDown config. So remove it from `external` list and don't copy the file into `dist`.
graphite-app
bot
force-pushed
the
09-11-build_napi_oxlint_do_not_extern_constants.mjs_
branch
from
df3ea39 to
21cbfbe
Compare
Base automatically changed from
09-11-build_napi_oxlint_simplify_build_script
to
main
September 12, 2025 04:15
Surprisingly, TSDown inlines the constants from `constants.mjs` into the bundled code, regardless of whether the file is listed as `external` in TSDown config. So remove it from `external` list and don't copy the file into `dist`.
graphite-app
bot
force-pushed
the
09-11-build_napi_oxlint_do_not_extern_constants.mjs_
branch
from
21cbfbe to
04b9809
Compare
graphite-app
bot
deleted the
09-11-build_napi_oxlint_do_not_extern_constants.mjs_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly, TSDown inlines the constants from
constants.mjsinto the bundled code, regardless of whether the file is listed asexternalin TSDown config. So remove it fromexternallist and don't copy the file intodist.