-
-
Notifications
You must be signed in to change notification settings - Fork 720
perf(oxfmt): Walk and format at the same time #13838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(oxfmt): Walk and format at the same time #13838
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors the oxfmt formatter to walk and format files simultaneously for better performance. Instead of collecting all file paths first and then processing them, the code now streams file entries through a channel as they are discovered and processes them immediately.
Key changes:
- Replaced batch collection with streaming via channels for immediate processing
- Modified the walk system to send individual entries instead of batched vectors
- Updated file counting logic to work with the streaming approach
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/oxfmt/src/walk.rs | Refactored to stream individual entries through channels instead of collecting batches |
| apps/oxfmt/src/service.rs | Updated to process streaming entries and removed batch-based entry management |
| apps/oxfmt/src/format.rs | Modified to handle streaming workflow and moved file counting to after processing |
| apps/oxfmt/tests/snapshots/... | Updated test snapshots to reflect new output format with "Checking formatting..." message |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
50267e7 to
e21e1bc
Compare
e21e1bc to
9372709
Compare
9372709 to
7b5d081
Compare
Merge activity
|
7b5d081 to
4b031e9
Compare
4b031e9 to
15f8f40
Compare
0918d44 to
59db021
Compare

Fixes #13836