Skip to content

fix(oxfmt): Fix up the half-finished lines #13840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

fix(oxfmt): Fix up the half-finished lines #13840

merged 1 commit into from
Sep 19, 2025

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Sep 17, 2025

Just tidied up first before moving on to another task.

@leaysgur leaysgur mentioned this pull request Sep 17, 2025
Merged
@github-actions github-actions bot added the C-bug Category - Bug label Sep 17, 2025
@leaysgur Graphite App
Copy link
Member Author

leaysgur commented Sep 17, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur requested a review from Dunqing September 17, 2025 04:31
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Sep 18, 2025
@Dunqing Graphite App
Copy link
Member

Dunqing commented Sep 18, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 09-17-perf_oxfmt_walk_and_format_at_the_same_time branch from 7b5d081 to 4b031e9 Compare September 18, 2025 14:04
graphite-app bot pushed a commit that referenced this pull request Sep 18, 2025
@leaysgur
fix(oxfmt): Fix up the half-finished lines (#13840)
0b04c1d 
Just tidied up first before moving on to another task.
@graphite-app graphite-app bot force-pushed the 09-17-fix_oxfmt_fix_up_the_half-finished_lines branch from 6acfbf1 to 0b04c1d Compare September 18, 2025 14:05
@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter labels Sep 18, 2025
@graphite-app graphite-app bot force-pushed the 09-17-perf_oxfmt_walk_and_format_at_the_same_time branch from 4b031e9 to 15f8f40 Compare September 18, 2025 14:08
graphite-app bot pushed a commit that referenced this pull request Sep 18, 2025
@leaysgur
fix(oxfmt): Fix up the half-finished lines (#13840)
3528454 
Just tidied up first before moving on to another task.
@graphite-app graphite-app bot force-pushed the 09-17-fix_oxfmt_fix_up_the_half-finished_lines branch from 0b04c1d to 3528454 Compare September 18, 2025 14:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 18, 2025
@graphite-app graphite-app bot changed the base branch from 09-17-perf_oxfmt_walk_and_format_at_the_same_time to graphite-base/13840 September 19, 2025 00:31
graphite-app bot pushed a commit that referenced this pull request Sep 19, 2025
@leaysgur
fix(oxfmt): Fix up the half-finished lines (#13840)
7ef5a46 
Just tidied up first before moving on to another task.
@graphite-app graphite-app bot force-pushed the 09-17-fix_oxfmt_fix_up_the_half-finished_lines branch from 3528454 to 7ef5a46 Compare September 19, 2025 00:37
@graphite-app graphite-app bot force-pushed the graphite-base/13840 branch from 15f8f40 to 59db021 Compare September 19, 2025 00:37
@graphite-app graphite-app bot changed the base branch from graphite-base/13840 to main September 19, 2025 00:37
graphite-app bot pushed a commit that referenced this pull request Sep 19, 2025
@leaysgur
fix(oxfmt): Fix up the half-finished lines (#13840)
051c444 
Just tidied up first before moving on to another task.
@graphite-app graphite-app bot force-pushed the 09-17-fix_oxfmt_fix_up_the_half-finished_lines branch from 7ef5a46 to 051c444 Compare September 19, 2025 00:38
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Sep 19, 2025
@leaysgur
fix(oxfmt): Fix up the half-finished lines (#13840)
55775ce 
Just tidied up first before moving on to another task.
@graphite-app graphite-app bot force-pushed the 09-17-fix_oxfmt_fix_up_the_half-finished_lines branch from 051c444 to 55775ce Compare September 19, 2025 01:17
Copilot AI review requested due to automatic review settings September 19, 2025 01:17
Copilot AI reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 55775ce into main Sep 19, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 09-17-fix_oxfmt_fix_up_the_half-finished_lines branch September 19, 2025 01:22
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 19, 2025
This was referenced Sep 19, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Dunqing Dunqing Dunqing approved these changes

Assignees

@Dunqing Dunqing

Labels

A-cli Area - CLI A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leaysgur @Dunqing