Skip to content

feat(transformer/class-properties): add debug_assertions for declare class #13907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 09-19-refactor_transformer_typescript_remove_integer_10_readonly_81999_integer_10_readonly_0_integer_10_readonly_81952_array_readonly_readonly_-_569jnrxghikls_0__bin_zsh_integer_10_readonly_0_array_readonly_integer_10_readonly_argc_0_
Choose a base branch
from
Draft

feat(transformer/class-properties): add debug_assertions for declare class #13907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions crates/oxc_transformer/src/es2022/class_properties/class.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ impl<'a> ClassProperties<'a, '_> {
body: &mut ClassBody<'a>,
ctx: &mut TraverseCtx<'a>,
) {
// Ignore TS class declarations
// TODO: Is this correct?
let Ancestor::ClassBody(class) = ctx.parent() else { unreachable!() };
if *class.declare() {
return;
}

debug_assert!(
!class.declare(),
"`declare` classes have already been removed in TypeScript's enter_statements."
);

// Get basic details about class
let is_declaration = *class.r#type() == ClassType::ClassDeclaration;
Expand Down Expand Up @@ -408,11 +408,10 @@ impl<'a> ClassProperties<'a, '_> {
class: &mut Class<'a>,
ctx: &mut TraverseCtx<'a>,
) {
// Ignore TS class declarations
// TODO: Is this correct?
if class.declare {
return;
}
debug_assert!(
!class.declare,
"`declare` classes have already been removed in TypeScript's enter_statements."
);

// Leave class expressions to `transform_class_expression_on_exit`
let class_details = self.current_class();
Expand Down Expand Up @@ -566,14 +565,6 @@ impl<'a> ClassProperties<'a, '_> {
expr: &mut Expression<'a>,
ctx: &mut TraverseCtx<'a>,
) {
let Expression::ClassExpression(class) = expr else { unreachable!() };

// Ignore TS class declarations
// TODO: Is this correct?
if class.declare {
return;
}

// Finish transform
let class_details = self.current_class();
if class_details.is_transform_required {
Expand Down
Loading