Skip to content

test(linter/plugins): test returning false from before hook skips visitation in ESLint #14061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

test(linter/plugins): test returning false from before hook skips visitation in ESLint #14061

merged 1 commit into from
Sep 24, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 23, 2025 •
edited
Loading

Add tests that a rule which is made ESLint-compatible by using defineRule skips AST traversal for the file in ESLint if before hook returns false - same as it does in Oxlint.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Sep 23, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Sep 23, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Sep 23, 2025
Merged
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review September 23, 2025 22:11
@overlookmotel overlookmotel self-assigned this Sep 23, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Sep 23, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Sep 23, 10:28 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 10:28 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 23, 10:33 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14060.
  • Sep 23, 10:33 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14060.
  • Sep 23, 11:40 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 11:40 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 23, 11:47 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Sep 23, 11:58 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 24, 12:03 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 24, 12:08 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
@overlookmotel overlookmotel force-pushed the 09-23-test_linter_plugins_test_returning_false_from_before_hook_skips_visitation_in_eslint branch from da57153 to 92e264d Compare September 23, 2025 23:31
@overlookmotel overlookmotel force-pushed the 09-23-fix_linter_plugins_definerule_accept_visitor_with_no_before___after_hooks branch from c661f6f to 01a122b Compare September 23, 2025 23:31
This was referenced Sep 23, 2025
Merged
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
@graphite-app graphite-app bot changed the base branch from 09-23-fix_linter_plugins_definerule_accept_visitor_with_no_before___after_hooks to graphite-base/14061 September 23, 2025 23:40
@graphite-app graphite-app bot changed the base branch from graphite-base/14061 to main September 23, 2025 23:45
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
@overlookmotel overlookmotel force-pushed the 09-23-test_linter_plugins_test_returning_false_from_before_hook_skips_visitation_in_eslint branch from 92e264d to b605733 Compare September 23, 2025 23:58
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
@overlookmotel
test(linter/plugins): test returning false from before hook skips…
f2b3934 
… visitation in ESLint (#14061)

Add tests that a rule which is made ESLint-compatible by using `defineRule` skips AST traversal for the file in ESLint if `before` hook returns `false` - same as it does in Oxlint.
@graphite-app graphite-app bot force-pushed the 09-23-test_linter_plugins_test_returning_false_from_before_hook_skips_visitation_in_eslint branch from b605733 to f2b3934 Compare September 24, 2025 00:03
@graphite-app graphite-app bot merged commit f2b3934 into main Sep 24, 2025
17 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 24, 2025
@graphite-app graphite-app bot deleted the 09-23-test_linter_plugins_test_returning_false_from_before_hook_skips_visitation_in_eslint branch September 24, 2025 00:08
@Boshen Boshen mentioned this pull request Sep 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel