fix(language_server): don't apply "ignore this rule" fixes for fixAll code action + command #14243

Sysix · 2025-09-29T17:10:13Z

This PR fixes a bug where on source.fixAll.oxc code action or oxc.fixAll command will append // oxlint-disable ... comments to the file.
This bug was introduced in #14183

Sysix · 2025-09-29T17:10:31Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR fixes a bug where "ignore this rule" fixes were being incorrectly applied during source.fixAll.oxc code actions and oxc.fixAll commands, which would add unwanted // oxlint-disable comments to files.

Modifies logic to skip ignore-type fixes when multiple fixes are available but only contain ignore/disable fixes
Adds test coverage to verify the fix works correctly for the fixAll code action scenario

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

File	Description
crates/oxc_language_server/src/worker.rs	Updates fix selection logic to skip ignore fixes for fixAll operations
crates/oxc_language_server/src/code_actions.rs	Applies the same fix selection logic to code actions and adds debug logging
editors/vscode/tests/code_actions.spec.ts	Adds test case to verify fixAll doesn't apply ignore-only fixes
editors/vscode/fixtures/fixall_code_action_ignore_only_disable_fix/*	Test fixture files for the new test case

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_language_server/src/code_actions.rs

crates/oxc_language_server/src/worker.rs

editors/vscode/fixtures/fixall_code_action_ignore_only_disable_fix/.oxlintrc.json

camc314 · 2025-09-29T20:37:21Z

Merge activity

Sep 29, 8:37 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 29, 8:37 PM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 29, 8:41 PM UTC: Merged by the Graphite merge queue.

… code action + command (#14243) This PR fixes a bug where on `source.fixAll.oxc` code action or `oxc.fixAll` command will append `// oxlint-disable ...` comments to the file. This bug was introduced in #14183

## [1.20.0] - 2025-10-06 ### 🚀 Features - d16df93 linter: Support disable directives for type aware rules (#14052) (camc314) - f5c6acc linter: Add `vue/no-export-in-script-setup` rule (#14307) (Sysix) - 353b153 linter: Implement eslint/no-param-reassign rule (#14341) (Matthew Davis) - a2914fe linter/plugins: Add `loc` field getter to all AST nodes (#14355) (overlookmotel) - 07193c2 linter/plugins: Implement `SourceCode#getAncestors` (#14346) (overlookmotel) - c8de6fe linter/plugins: Add `parent` field to AST nodes (#14345) (overlookmotel) - 5505a86 linter/plugins: Include `range` field in AST (#14321) (overlookmotel) - 3656908 rust: Oxc-index-vec v4.0 (#14254) (Boshen) - 1347de4 linter/plugins: Accept diagnostics with `loc` (#14304) (overlookmotel) - aefc8b3 linter/plugins: Implement `SourceCode#getIndexFromLoc` and `getLocFromIndex` (#14303) (overlookmotel) - 93807db linter/plugins: Implement `SourceCode#lines` property (#14290) (overlookmotel) - 2f8c985 linter/plugins: Implement `SourceCode#visitorKeys` property (#14289) (overlookmotel) - b69028f linter/plugins: Implement `SourceCode#ast` property (#14287) (overlookmotel) - d8d3d18 linter: Add `vue/prefer-import-from-vue` rule (#14284) (Sysix) - f0e760b linter: Add `vue/define-props-destructuring` rule (#14272) (Sysix) - bdf9010 linter/plugins: Add `SourceCode` API (#14281) (overlookmotel) - 7f450fc linter/unicorn: Implement require-module-specifiers (#13089) (keita hino) - a1e7154 linter/unicorn: Implement prefer-classlist-toggle (#14262) (camc314) - 8217dce linter/unicorn: Implement no-unnecessary-array-splice-count (#14255) (camc314) - 3d5db4a linter/unicorn: Implement no-useless-error-capture-stack-trace (#14222) (camc314) - b3b482a linter/unicorn: Implement prefer-top-level-await (#14247) (camc314) - 7931be8 linter/unicorn: Implement prefer-class-fields (#14245) (camc314) - a39434a linter/unicorn: Implement prefer-at (#14232) (camc314) ### 🐛 Bug Fixes - e605222 linter/no-useless-undefined: Correctly respect `checkArguments` option (#14369) (camc314) - f1bc608 linter: Fix flaky import/no_cycle test (#14328) (Boshen) - 9a902c0 linter/plugins: Make `range` field non-optional on AST types (#14354) (overlookmotel) - 0a42d7f tsgolint: Report errors if we fail to parse tsgolint diagnostic messages (#14301) (camc314) - 42f8d7e linter/react-hooks: Fix diagnostic message for literal in dependency array (#14266) (camc314) - ece91c5 linter/react-hooks: Fix diagnostic message for duplicate dependency in array (#14265) (camc314) - 864fa0e linter/no-unused-expression: False positive with satisfies expressions (#14259) (camc314) - adff069 language_server: Don't apply "ignore this rule" fixes for fixAll code action + command (#14243) (Sysix) - 46cceb8 linter/rules-of-hooks: Correctly place primary span to fix disable directive (#14237) (camc314) ### 🚜 Refactor - 1489376 napi/parser, linter/plugins: Minify walker code (#14376) (overlookmotel) - c8eeeb5 linter/plugins: Remove build-time dependency on `napi/parser` (#14374) (overlookmotel) - fb1a067 linter/plugins: Bundle walker and AST types map (#14373) (overlookmotel) - 93d8164 linter/plugins: Export AST types direct from `oxlint` package (#14353) (overlookmotel) - 230d996 linter/plugins: `SourceCode#getText` use `range` (#14352) (overlookmotel) - 6e52bbd linter/plugins: Move location-related code into separate file (#14350) (overlookmotel) - 13f1003 linter/plugins: Share `ast` between files (#14349) (overlookmotel) - 00dde41 tsgolint: Make parsing `TsGoLintMessage` parsing errors an enum (#14300) (camc314) - fc314f5 tsgolint: Make `MessageType` parsing more idomatic (#14299) (camc314) - a24c36e language-server/tsgolint: Use an iterator for tsgolint message parsing (#14298) (camc314) - 8be432a tsgolint: Use an iterator for tsgolint message parsing (#14297) (camc314) - 57daa54 tsgolint: Remove always `Some` option wrapper (#14296) (camc314) - 79eadf8 linter: Introduce `LintRunner` (#14051) (camc314) - 65873ba linter/plugins: Add stubs for all `SourceCode` methods (#14285) (overlookmotel) - 989ce2f linter/plugins: Convert `Node` type to interface (#14280) (overlookmotel) - 891fc47 language_server: Share code for command `oxc.fixAll` and code action `source.fixAll.oxc` (#14244) (Sysix) - 7fe930c language_server: Remove unused fixture files (#14246) (Sysix) - 2b2c345 language-server: Move `generate_inverted_diagnostics` to `error_with_position` (#14118) (camc314) ### ⚡ Performance - fa3712d language_server: Create less `ExternalPluginStore`s (#14378) (overlookmotel) - e75d42d napi/parser, linter/plugins: Remove runtime `preserveParens` option from raw transfer deserializers (#14338) (overlookmotel) - 2e57351 linter/plugins: Initialize `lineStartOffsets` as `[0]` (#14302) (overlookmotel) - c27a393 linter/plugins: Deserialize AST on demand (#14288) (overlookmotel) - 95a8cc4 linter/plugins: Use singleton for `SourceCode` (#14286) (overlookmotel) ### 🧪 Testing - 0061ce7 linter: Add more tests for disable directives in partial loadable files (#14371) (camc314) - 1387aaa linter/plugins: Test `createOnce` returning no visitor functions (#14279) (overlookmotel) - 55ebb8b linter: Add test for `disable_for_this_section` fix (#14240) (Sysix) - a7e8662 linter: Port unicorn test cases to no-named-default (#14239) (camc314) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Sep 29, 2025

Sysix force-pushed the 09-29-fix_language_server_don_t_apply_ignore_this_rule_fixes_for_fixall_code_action_command branch 3 times, most recently from c8fa479 to cea33a5 Compare September 29, 2025 17:27

Sysix requested a review from Copilot September 29, 2025 18:26

Copilot AI reviewed Sep 29, 2025

View reviewed changes

crates/oxc_language_server/src/code_actions.rs Show resolved Hide resolved

crates/oxc_language_server/src/worker.rs Show resolved Hide resolved

editors/vscode/fixtures/fixall_code_action_ignore_only_disable_fix/.oxlintrc.json Outdated Show resolved Hide resolved

Sysix force-pushed the 09-29-fix_language_server_don_t_apply_ignore_this_rule_fixes_for_fixall_code_action_command branch from cea33a5 to 7bee177 Compare September 29, 2025 18:31

Sysix marked this pull request as ready for review September 29, 2025 18:40

Sysix requested a review from camc314 as a code owner September 29, 2025 18:40

Sysix mentioned this pull request Sep 29, 2025

refactor(language_server): share code for command oxc.fixAll and code action source.fixAll.oxc #14244

Merged

camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 29, 2025

camc314 approved these changes Sep 29, 2025

View reviewed changes

fix(language_server): don't apply "ignore this rule" fixes for fixAll…

adff069

… code action + command (#14243) This PR fixes a bug where on `source.fixAll.oxc` code action or `oxc.fixAll` command will append `// oxlint-disable ...` comments to the file. This bug was introduced in #14183

graphite-app bot force-pushed the 09-29-fix_language_server_don_t_apply_ignore_this_rule_fixes_for_fixall_code_action_command branch from 7bee177 to adff069 Compare September 29, 2025 20:37

graphite-app bot merged commit adff069 into main Sep 29, 2025
20 checks passed

graphite-app bot deleted the 09-29-fix_language_server_don_t_apply_ignore_this_rule_fixes_for_fixall_code_action_command branch September 29, 2025 20:41

camc314 mentioned this pull request Sep 30, 2025

VSCode: auto fix adds ignore directives #14261

Closed

Boshen mentioned this pull request Oct 6, 2025

release(oxlint): v1.20.0 #14381

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(language_server): don't apply "ignore this rule" fixes for fixAll code action + command #14243

fix(language_server): don't apply "ignore this rule" fixes for fixAll code action + command #14243

Uh oh!

Sysix commented Sep 29, 2025 •

edited

Loading

Uh oh!

Sysix commented Sep 29, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 commented Sep 29, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(language_server): don't apply "ignore this rule" fixes for fixAll code action + command #14243

fix(language_server): don't apply "ignore this rule" fixes for fixAll code action + command #14243

Uh oh!

Conversation

Sysix commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 commented Sep 29, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Sep 29, 2025 •

edited

Loading

Sysix commented Sep 29, 2025 •

edited

Loading

camc314 commented Sep 29, 2025 •

edited by graphite-app bot

Loading