Skip to content

Conversation

@matthewdavi
Copy link
Contributor

Summary

  • port ESLint's no-param-reassign rule to oxlint, including full option handling (props, ignore lists)
  • add comprehensive pass/fail coverage mirroring the upstream test suite, and update snapshots
  • register the rule with the ESLint catalog so it is available via oxlint

@matthewdavi matthewdavi requested a review from camc314 as a code owner October 4, 2025 21:16
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Oct 4, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 4, 2025

CodSpeed Performance Report

Merging #14341 will not alter performance

Comparing matthewdavi:feat/no-param-reassign (4bcd38e) with main (4a5249f)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (3788785) during the generation of this report, so 4a5249f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@matthewdavi matthewdavi force-pushed the feat/no-param-reassign branch 5 times, most recently from 7f6f810 to 8d459ad Compare October 5, 2025 13:27
@camc314 camc314 force-pushed the feat/no-param-reassign branch from 8d459ad to 84a3af7 Compare October 6, 2025 08:04
@camc314 camc314 requested a review from Copilot October 6, 2025 08:12
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ports ESLint's no-param-reassign rule to oxlint with comprehensive option handling for property reassignment detection and configurable ignore lists. The implementation adds functionality to detect and warn against reassignment of function parameters and their properties.

  • Adds the complete no-param-reassign rule implementation with support for props option and ignore lists
  • Includes comprehensive test coverage mirroring the upstream ESLint test suite
  • Registers the rule in the ESLint catalog for availability via oxlint

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File Description
crates/oxc_linter/src/rules/eslint/no_param_reassign.rs Complete implementation of the no-param-reassign rule with configuration parsing and detection logic
crates/oxc_linter/src/rules.rs Registration of the new rule in the linter's rule catalog
crates/oxc_linter/src/snapshots/eslint_no_param_reassign.snap Test snapshots showing expected diagnostic output for rule violations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@camc314 camc314 merged commit 353b153 into oxc-project:main Oct 6, 2025
20 checks passed
@Boshen Boshen mentioned this pull request Oct 6, 2025
camc314 added a commit that referenced this pull request Oct 6, 2025
## [1.20.0] - 2025-10-06

### 🚀 Features

- d16df93 linter: Support disable directives for type aware rules
(#14052) (camc314)
- f5c6acc linter: Add `vue/no-export-in-script-setup` rule (#14307)
(Sysix)
- 353b153 linter: Implement eslint/no-param-reassign rule (#14341)
(Matthew Davis)
- a2914fe linter/plugins: Add `loc` field getter to all AST nodes
(#14355) (overlookmotel)
- 07193c2 linter/plugins: Implement `SourceCode#getAncestors` (#14346)
(overlookmotel)
- c8de6fe linter/plugins: Add `parent` field to AST nodes (#14345)
(overlookmotel)
- 5505a86 linter/plugins: Include `range` field in AST (#14321)
(overlookmotel)
- 3656908 rust: Oxc-index-vec v4.0 (#14254) (Boshen)
- 1347de4 linter/plugins: Accept diagnostics with `loc` (#14304)
(overlookmotel)
- aefc8b3 linter/plugins: Implement `SourceCode#getIndexFromLoc` and
`getLocFromIndex` (#14303) (overlookmotel)
- 93807db linter/plugins: Implement `SourceCode#lines` property (#14290)
(overlookmotel)
- 2f8c985 linter/plugins: Implement `SourceCode#visitorKeys` property
(#14289) (overlookmotel)
- b69028f linter/plugins: Implement `SourceCode#ast` property (#14287)
(overlookmotel)
- d8d3d18 linter: Add `vue/prefer-import-from-vue` rule (#14284) (Sysix)
- f0e760b linter: Add `vue/define-props-destructuring` rule (#14272)
(Sysix)
- bdf9010 linter/plugins: Add `SourceCode` API (#14281) (overlookmotel)
- 7f450fc linter/unicorn: Implement require-module-specifiers (#13089)
(keita hino)
- a1e7154 linter/unicorn: Implement prefer-classlist-toggle (#14262)
(camc314)
- 8217dce linter/unicorn: Implement no-unnecessary-array-splice-count
(#14255) (camc314)
- 3d5db4a linter/unicorn: Implement no-useless-error-capture-stack-trace
(#14222) (camc314)
- b3b482a linter/unicorn: Implement prefer-top-level-await (#14247)
(camc314)
- 7931be8 linter/unicorn: Implement prefer-class-fields (#14245)
(camc314)
- a39434a linter/unicorn: Implement prefer-at (#14232) (camc314)

### 🐛 Bug Fixes

- e605222 linter/no-useless-undefined: Correctly respect
`checkArguments` option (#14369) (camc314)
- f1bc608 linter: Fix flaky import/no_cycle test (#14328) (Boshen)
- 9a902c0 linter/plugins: Make `range` field non-optional on AST types
(#14354) (overlookmotel)
- 0a42d7f tsgolint: Report errors if we fail to parse tsgolint
diagnostic messages (#14301) (camc314)
- 42f8d7e linter/react-hooks: Fix diagnostic message for literal in
dependency array (#14266) (camc314)
- ece91c5 linter/react-hooks: Fix diagnostic message for duplicate
dependency in array (#14265) (camc314)
- 864fa0e linter/no-unused-expression: False positive with satisfies
expressions (#14259) (camc314)
- adff069 language_server: Don't apply "ignore this rule" fixes for
fixAll code action + command (#14243) (Sysix)
- 46cceb8 linter/rules-of-hooks: Correctly place primary span to fix
disable directive (#14237) (camc314)

### 🚜 Refactor

- 1489376 napi/parser, linter/plugins: Minify walker code (#14376)
(overlookmotel)
- c8eeeb5 linter/plugins: Remove build-time dependency on `napi/parser`
(#14374) (overlookmotel)
- fb1a067 linter/plugins: Bundle walker and AST types map (#14373)
(overlookmotel)
- 93d8164 linter/plugins: Export AST types direct from `oxlint` package
(#14353) (overlookmotel)
- 230d996 linter/plugins: `SourceCode#getText` use `range` (#14352)
(overlookmotel)
- 6e52bbd linter/plugins: Move location-related code into separate file
(#14350) (overlookmotel)
- 13f1003 linter/plugins: Share `ast` between files (#14349)
(overlookmotel)
- 00dde41 tsgolint: Make parsing `TsGoLintMessage` parsing errors an
enum (#14300) (camc314)
- fc314f5 tsgolint: Make `MessageType` parsing more idomatic (#14299)
(camc314)
- a24c36e language-server/tsgolint: Use an iterator for tsgolint message
parsing (#14298) (camc314)
- 8be432a tsgolint: Use an iterator for tsgolint message parsing
(#14297) (camc314)
- 57daa54 tsgolint: Remove always `Some` option wrapper (#14296)
(camc314)
- 79eadf8 linter: Introduce `LintRunner` (#14051) (camc314)
- 65873ba linter/plugins: Add stubs for all `SourceCode` methods
(#14285) (overlookmotel)
- 989ce2f linter/plugins: Convert `Node` type to interface (#14280)
(overlookmotel)
- 891fc47 language_server: Share code for command `oxc.fixAll` and code
action `source.fixAll.oxc` (#14244) (Sysix)
- 7fe930c language_server: Remove unused fixture files (#14246) (Sysix)
- 2b2c345 language-server: Move `generate_inverted_diagnostics` to
`error_with_position` (#14118) (camc314)

### ⚡ Performance

- fa3712d language_server: Create less `ExternalPluginStore`s (#14378)
(overlookmotel)
- e75d42d napi/parser, linter/plugins: Remove runtime `preserveParens`
option from raw transfer deserializers (#14338) (overlookmotel)
- 2e57351 linter/plugins: Initialize `lineStartOffsets` as `[0]`
(#14302) (overlookmotel)
- c27a393 linter/plugins: Deserialize AST on demand (#14288)
(overlookmotel)
- 95a8cc4 linter/plugins: Use singleton for `SourceCode` (#14286)
(overlookmotel)

### 🧪 Testing

- 0061ce7 linter: Add more tests for disable directives in partial
loadable files (#14371) (camc314)
- 1387aaa linter/plugins: Test `createOnce` returning no visitor
functions (#14279) (overlookmotel)
- 55ebb8b linter: Add test for `disable_for_this_section` fix (#14240)
(Sysix)
- a7e8662 linter: Port unicorn test cases to no-named-default (#14239)
(camc314)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants