Skip to content

fix(package.json): fix quotes for windows compat #14388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

fix(package.json): fix quotes for windows compat #14388

merged 1 commit into from
Oct 6, 2025

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 6, 2025 •
edited
Loading

single quotes appear not to work on windows:

info: downloading component 'rust-std' for 'wasm32-wasip1-threads'
info: installing component 'rust-std' for 'wasm32-wasip1-threads'
> oxc@ build-test D:\a\oxc\oxc
> pnpm --workspace-concurrency=1 --filter './napi/*' --filter './apps/*' build-test
No projects matched the filters in "D:\a\oxc\oxc"
> oxc@ test D:\a\oxc\oxc
> pnpm --workspace-concurrency=1 --filter './napi/*' --filter './apps/*' test
No projects matched the filters in "D:\a\oxc\oxc"

@github-actions github-actions bot added the C-bug Category - Bug label Oct 6, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 mentioned this pull request Oct 6, 2025
Merged
@camc314 camc314 requested a review from Boshen October 6, 2025 21:37
@camc314 camc314 marked this pull request as ready for review October 6, 2025 21:37
Copilot AI review requested due to automatic review settings October 6, 2025 21:37
Copilot AI reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Windows compatibility issues in package.json scripts by replacing single quotes with double quotes in pnpm filter arguments. The change ensures that workspace filtering works correctly on Windows systems where single quotes are not properly interpreted.

  • Replaces single quotes with double quotes in all pnpm filter arguments
  • Fixes "No projects matched the filters" error on Windows builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

This was referenced Oct 6, 2025
Merged
Closed
@overlookmotel overlookmotel force-pushed the c/10-06-fix_package.json_fix_quotes_for_windows_compat branch from 4cc19e7 to 3cd0307 Compare October 6, 2025 23:01
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 6, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 6, 2025 •
edited by graphite-app bot
Loading

Merge activity

@camc314
fix(package.json): fix quotes for windows compat (#14388)
f793011 
single quotes appear not to work on windows:

```
info: downloading component 'rust-std' for 'wasm32-wasip1-threads'
info: installing component 'rust-std' for 'wasm32-wasip1-threads'
> oxc@ build-test D:\a\oxc\oxc
> pnpm --workspace-concurrency=1 --filter './napi/*' --filter './apps/*' build-test
No projects matched the filters in "D:\a\oxc\oxc"
> oxc@ test D:\a\oxc\oxc
> pnpm --workspace-concurrency=1 --filter './napi/*' --filter './apps/*' test
No projects matched the filters in "D:\a\oxc\oxc"
```
@graphite-app graphite-app bot force-pushed the c/10-06-fix_package.json_fix_quotes_for_windows_compat branch from 3cd0307 to f793011 Compare October 6, 2025 23:21
@graphite-app graphite-app bot merged commit f793011 into main Oct 6, 2025
17 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 6, 2025
@graphite-app graphite-app bot deleted the c/10-06-fix_package.json_fix_quotes_for_windows_compat branch October 6, 2025 23:26
@camc314 camc314 mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@overlookmotel overlookmotel overlookmotel approved these changes

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@Boshen Boshen

Labels

C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camc314 @overlookmotel @Boshen