feat(ci): run napi tests on windows #14383

camc314 · 2025-10-06T17:45:32Z

No description provided.

camc314 · 2025-10-06T17:45:48Z

feat(ci): run napi tests on windows #14383 : 2 dependent PRs (#14393 , #14409 ) 👈 (View in Graphite)
fix(oxlint): normalize path separators in snapshot tests #14406
test(oxlint): update .gitattributes to force lf line endings #14404
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sysix · 2025-10-06T18:13:55Z

@camc314 first guess (because I had the problem on my local machine too):
Use git config --global core.longpaths true

camc314 · 2025-10-06T21:31:57Z

yep, that got it working, thanks @Sysix

camc314 · 2025-10-06T21:55:44Z

appears we are running into vitest-dev/vitest#8201

.github/workflows/ci.yml

apps/oxlint/test/eslint-compat.test.ts

Follow-on after #14383. Remove redundant lines from workflow + add a comment about why longer timeout on ESLint compat tests.

## [1.21.0] - 2025-10-08 ### 🚀 Features - 576be20 linter/plugins: Support selectors DSL (#14435) (overlookmotel) - b2de44f linter/plugins: Support interpolation in normal diagnostic `message` (#14419) (overlookmotel) - 382c5be linter/plugins: Support placeholders in messageIds (#14416) (camc314) - 529e88e linter/plugins: Support `messageId`s (#14415) (camc314) - 83e7824 linter: Add `vue/require-default-export` rule (#14351) (Sysix) - ff98536 linter: Add `vue/no-import-compiler-macros` rule (#14335) (Sysix) - 0ec0847 ci: Run napi tests on windows (#14383) (camc314) ### 🐛 Bug Fixes - 11e0440 linter/jsx-handler-name: Improve handler name position in error messages (#14174) (Takuji Shimokawa) - 493082c language_server: Use the first Span of the message as the primary Diagnostic range (#14057) (Sysix) - 88ec1bd linter/plugins: Fix error messages (#14423) (overlookmotel) - 18616c2 oxlint: Ignore fixtures dir for vitest (#14414) (camc314) - ec02fe8 oxlint: Normalize path separators in snapshot tests (#14406) (camc314) - 6e8d2f6 language_server: Ignore JS plugins (#14379) (overlookmotel) - 96663fb linter/plugins: Do not call `before` hook if empty visitor (#14401) (overlookmotel) - 52f04bd linter: Use `pathToFileURL` for importing plugins to ensure correct URL format (#14394) (camc314) - 1ea0d46 oxlint: Resolve tsdown deprecation warning (#14389) (camc314) - bb679b5 linter: Promise/prefer-await-to-then strict option not reading from config (#14382) (camc314) ### 🚜 Refactor - 3374b8e linter/language_server: Move all lsp relevant code to `oxc_language_server` crate (#14430) (Sysix) - d24b74e linter/language_server: `oxc_linter::TsgoLinter::run_source` returns `Message` (#14429) (Sysix) - e5b7fb2 linter/language_server: `oxc_linter::Runtime::run_source` returns `Message` (#14428) (Sysix) - 3b26bf3 linter/plugins: Split adding visit function to compiler visitor into multiple functions (#14433) (overlookmotel) - af3a75e linter/plugins: Track ancestors while walking AST (#14432) (overlookmotel) - f279f0b linter/plugins: Do not lazy-load visitor keys (#14431) (overlookmotel) - 5e99ed3 linter/plugins: Allow nullish values as `message` or `messageId` (#14422) (overlookmotel) - dc30938 linter/plugins: Remove default value from `Context` constructor (#14421) (overlookmotel) - 28cfae0 oxlint: Use `vitest`s built in file snapshot comparison (#14392) (camc314) - 06b0e9f linter/plugins: Convert generated files to TS (#14385) (overlookmotel) - 52f35c6 napi/parser, linter/plugins: Rename `types.js` to `type_ids.js` (#14384) (overlookmotel) ### ⚡ Performance - 26435a1 linter/plugins: Small perf optimizations (#14420) (overlookmotel) - d8a8be1 linter/plugins: Avoid private methods (#14418) (overlookmotel) ### 🧪 Testing - d8da4a4 linter/plugins: Clarify tests for message placeholders (#14417) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch 2 times, most recently from e7a55e3 to 8824e82 Compare October 6, 2025 21:28

camc314 changed the base branch from main to graphite-base/14383 October 6, 2025 21:36

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from 8824e82 to d451c23 Compare October 6, 2025 21:36

camc314 force-pushed the graphite-base/14383 branch from d29364c to 4cc19e7 Compare October 6, 2025 21:36

camc314 changed the base branch from graphite-base/14383 to c/10-06-fix_package.json_fix_quotes_for_windows_compat October 6, 2025 21:36

camc314 mentioned this pull request Oct 6, 2025

fix(package.json): fix quotes for windows compat #14388

Merged

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from d451c23 to 1757c27 Compare October 6, 2025 21:43

github-actions bot added the A-parser Area - Parser label Oct 6, 2025

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch 3 times, most recently from a416227 to 60d3cb2 Compare October 6, 2025 22:14

camc314 changed the title ~~ci: run napi tests on windows~~ feat(ci): run napi tests on windows Oct 6, 2025

github-actions bot added the C-enhancement Category - New feature or request label Oct 6, 2025

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from 60d3cb2 to aef896c Compare October 6, 2025 22:25

github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Oct 6, 2025

camc314 changed the base branch from c/10-06-fix_package.json_fix_quotes_for_windows_compat to graphite-base/14383 October 6, 2025 22:31

camc314 mentioned this pull request Oct 6, 2025

refactor(oxlint): use vitests built in file snapshot comparison #14392

Merged

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from aef896c to a841c56 Compare October 6, 2025 22:37

camc314 changed the base branch from graphite-base/14383 to c/10-06-refactor_oxlint_use_vitest_s_built_in_file_snapshot_comparison October 6, 2025 22:37

camc314 mentioned this pull request Oct 6, 2025

fix(oxlint): fix custom plugin import bug on windows #14393

Closed

camc314 marked this pull request as ready for review October 6, 2025 22:39

graphite-app bot reviewed Oct 6, 2025

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from a841c56 to c3b0172 Compare October 6, 2025 22:42

camc314 assigned overlookmotel Oct 6, 2025

graphite-app bot force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from 90e42b8 to 6caadb0 Compare October 7, 2025 11:06

graphite-app bot changed the base branch from graphite-base/14383 to main October 7, 2025 11:06

graphite-app bot force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from 6caadb0 to af1d360 Compare October 7, 2025 11:07

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from af1d360 to 46a0999 Compare October 7, 2025 11:16

overlookmotel mentioned this pull request Oct 7, 2025

test(napi/parser): fix and clarify exclude tests logic #14409

Merged

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from 46a0999 to 2bb8c70 Compare October 7, 2025 11:24

graphite-app bot reviewed Oct 7, 2025

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

overlookmotel reviewed Oct 7, 2025

View reviewed changes

apps/oxlint/test/eslint-compat.test.ts Outdated Show resolved Hide resolved

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch 2 times, most recently from f6e8850 to 8b3fdf3 Compare October 7, 2025 11:27

Boshen force-pushed the main branch from d33c112 to 1f5167a Compare October 7, 2025 11:31

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch 3 times, most recently from e07c1b5 to 8bd5122 Compare October 7, 2025 11:41

camc314 requested a review from overlookmotel October 7, 2025 11:41

camc314 removed the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025

camc314 force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from 8bd5122 to 5d214f6 Compare October 7, 2025 11:42

overlookmotel approved these changes Oct 7, 2025

View reviewed changes

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025

feat(ci): run napi tests on windows (#14383)

0ec0847

graphite-app bot force-pushed the c/10-06-ci_run_napi_tests_on_windows branch from 5d214f6 to 0ec0847 Compare October 7, 2025 13:56

graphite-app bot merged commit 0ec0847 into main Oct 7, 2025
20 checks passed

graphite-app bot deleted the c/10-06-ci_run_napi_tests_on_windows branch October 7, 2025 14:01

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025

overlookmotel mentioned this pull request Oct 7, 2025

ci(napi): remove redundant step from workflow + add comment #14412

Merged

graphite-app bot pushed a commit that referenced this pull request Oct 7, 2025

ci(napi): remove redundant step from workflow + add comment (#14412)

3192574

Follow-on after #14383. Remove redundant lines from workflow + add a comment about why longer timeout on ESLint compat tests.

This was referenced Oct 8, 2025

release(oxlint): v1.21.0 #14439

Closed

release(oxlint): v1.21.0 #14441

Merged

Boshen mentioned this pull request Oct 15, 2025

release(crates): v0.95.0 #14619

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(ci): run napi tests on windows #14383

feat(ci): run napi tests on windows #14383

Uh oh!

camc314 commented Oct 6, 2025 •

edited by overlookmotel

Loading

Uh oh!

camc314 commented Oct 6, 2025 •

edited by overlookmotel

Loading

Uh oh!

Sysix commented Oct 6, 2025 •

edited

Loading

Uh oh!

camc314 commented Oct 6, 2025

Uh oh!

camc314 commented Oct 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

feat(ci): run napi tests on windows #14383

feat(ci): run napi tests on windows #14383

Uh oh!

Conversation

camc314 commented Oct 6, 2025 • edited by overlookmotel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Oct 6, 2025 • edited by overlookmotel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Sysix commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Oct 6, 2025

Uh oh!

camc314 commented Oct 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camc314 commented Oct 6, 2025 •

edited by overlookmotel

Loading

camc314 commented Oct 6, 2025 •

edited by overlookmotel

Loading

Sysix commented Oct 6, 2025 •

edited

Loading