fix(linter): use pathToFileURL for importing plugins to ensure correct URL format
#14394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes plugin loading in the oxlint linter by ensuring correct URL format when importing plugins dynamically. The change addresses an issue where file paths weren't properly converted to file URLs before being passed to the import() function.
- Adds
pathToFileURLimport from Node.jsurlmodule - Converts file paths to proper file URLs before dynamic import
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
overlookmotel
approved these changes
Oct 6, 2025
Merge activity
|
graphite-app
bot
force-pushed
the
c/10-06-fix_linter_use_pathtofileurl_for_importing_plugins_to_ensure_correct_url_format
branch
from
97ad2f5 to
52f04bd
Compare
graphite-app
bot
deleted the
c/10-06-fix_linter_use_pathtofileurl_for_importing_plugins_to_ensure_correct_url_format
branch
This was referenced Oct 8, 2025
camc314
added a commit
that referenced
this pull request
Oct 8, 2025
## [1.21.0] - 2025-10-08 ### 🚀 Features - 576be20 linter/plugins: Support selectors DSL (#14435) (overlookmotel) - b2de44f linter/plugins: Support interpolation in normal diagnostic `message` (#14419) (overlookmotel) - 382c5be linter/plugins: Support placeholders in messageIds (#14416) (camc314) - 529e88e linter/plugins: Support `messageId`s (#14415) (camc314) - 83e7824 linter: Add `vue/require-default-export` rule (#14351) (Sysix) - ff98536 linter: Add `vue/no-import-compiler-macros` rule (#14335) (Sysix) - 0ec0847 ci: Run napi tests on windows (#14383) (camc314) ### 🐛 Bug Fixes - 11e0440 linter/jsx-handler-name: Improve handler name position in error messages (#14174) (Takuji Shimokawa) - 493082c language_server: Use the first Span of the message as the primary Diagnostic range (#14057) (Sysix) - 88ec1bd linter/plugins: Fix error messages (#14423) (overlookmotel) - 18616c2 oxlint: Ignore fixtures dir for vitest (#14414) (camc314) - ec02fe8 oxlint: Normalize path separators in snapshot tests (#14406) (camc314) - 6e8d2f6 language_server: Ignore JS plugins (#14379) (overlookmotel) - 96663fb linter/plugins: Do not call `before` hook if empty visitor (#14401) (overlookmotel) - 52f04bd linter: Use `pathToFileURL` for importing plugins to ensure correct URL format (#14394) (camc314) - 1ea0d46 oxlint: Resolve tsdown deprecation warning (#14389) (camc314) - bb679b5 linter: Promise/prefer-await-to-then strict option not reading from config (#14382) (camc314) ### 🚜 Refactor - 3374b8e linter/language_server: Move all lsp relevant code to `oxc_language_server` crate (#14430) (Sysix) - d24b74e linter/language_server: `oxc_linter::TsgoLinter::run_source` returns `Message` (#14429) (Sysix) - e5b7fb2 linter/language_server: `oxc_linter::Runtime::run_source` returns `Message` (#14428) (Sysix) - 3b26bf3 linter/plugins: Split adding visit function to compiler visitor into multiple functions (#14433) (overlookmotel) - af3a75e linter/plugins: Track ancestors while walking AST (#14432) (overlookmotel) - f279f0b linter/plugins: Do not lazy-load visitor keys (#14431) (overlookmotel) - 5e99ed3 linter/plugins: Allow nullish values as `message` or `messageId` (#14422) (overlookmotel) - dc30938 linter/plugins: Remove default value from `Context` constructor (#14421) (overlookmotel) - 28cfae0 oxlint: Use `vitest`s built in file snapshot comparison (#14392) (camc314) - 06b0e9f linter/plugins: Convert generated files to TS (#14385) (overlookmotel) - 52f35c6 napi/parser, linter/plugins: Rename `types.js` to `type_ids.js` (#14384) (overlookmotel) ### ⚡ Performance - 26435a1 linter/plugins: Small perf optimizations (#14420) (overlookmotel) - d8a8be1 linter/plugins: Avoid private methods (#14418) (overlookmotel) ### 🧪 Testing - d8da4a4 linter/plugins: Clarify tests for message placeholders (#14417) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writing a test for this is too hard
fixes #14375