Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 8, 2025

I am still seeing this failure on some PRs

2025-10-07T17:20:30.0133725Z �[31m   �[31m�[31m fixtures�[2m > �[22mtarget/antd.js�[39m�[33m 5032�[2mms�[22m�[39m
2025-10-07T17:20:30.0133896Z �[31m     → Test timed out in 5000ms.
2025-10-07T17:20:30.0134434Z If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".�[39m

@github-actions github-actions bot added A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Oct 8, 2025
Copy link
Contributor Author

camc314 commented Oct 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review October 8, 2025 09:11
Copilot AI review requested due to automatic review settings October 8, 2025 09:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the timeout for the "fixtures" test suite from the default 5000ms to 10000ms to address timeout failures occurring on some PRs during CI runs.

  • Adds a timeout configuration of 10,000ms to the fixtures test suite

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel
Copy link
Member

I think that's actually a different test from the one that was intermittently failing before.

The one I saw failing previously was "range & parent fixtures" which was added in #14344, whereas this test is "fixtures". Prior to #14344, this "fixtures" test never timed out, but now it does. My guess is that because the tests run concurrently, one test can slow down another, hence why unrelated changes can cause problems with a pre-existing test.

Anyway, I found that setting timeout option on the "range & parent fixtures" test didn't seem to do anything. Don't know why, but I just disabled the test completely in #14424. Probably we need to do the same here.

#14446 is an alternative to this PR which disables both the slow tests in CI.

@overlookmotel
Copy link
Member

Superseded by #14446.

@overlookmotel overlookmotel deleted the c/10-08-test_napi_parser_increase_timeout_flag_for_fixture_tests branch October 8, 2025 17:25
graphite-app bot pushed a commit that referenced this pull request Oct 8, 2025
…14446)

The raw transfer test on `antd.js` fixture is timing out sometimes on CI. We already disabled the "range & parent" test on this fixture. Disable the other test on it too. But only skip these tests in CI.

(alternative to #14438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants