-
-
Notifications
You must be signed in to change notification settings - Fork 715
test(napi/parser): disable raw transfer tests on antd.js fixture
#14446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(napi/parser): disable raw transfer tests on antd.js fixture
#14446
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables raw transfer tests on the antd.js fixture to prevent CI timeouts by conditionally skipping the problematic fixture when running in CI environments.
- Conditionally removes the
antd.jsfixture from test runs whenprocess.env.CIis set - Simplifies the "range & parent" test configuration by removing the previous filtering logic
- Removes unused import
sep as pathSepsince it's no longer needed
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
camc314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nits, feel free to ignore
Merge activity
|
a55d4ed to
f293e3e
Compare

The raw transfer test on
antd.jsfixture is timing out sometimes on CI. We already disabled the "range & parent" test on this fixture. Disable the other test on it too. But only skip these tests in CI.(alternative to #14438)