Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 8, 2025

The raw transfer test on antd.js fixture is timing out sometimes on CI. We already disabled the "range & parent" test on this fixture. Disable the other test on it too. But only skip these tests in CI.

(alternative to #14438)

@github-actions github-actions bot added A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Oct 8, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review October 8, 2025 17:09
Copilot AI review requested due to automatic review settings October 8, 2025 17:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables raw transfer tests on the antd.js fixture to prevent CI timeouts by conditionally skipping the problematic fixture when running in CI environments.

  • Conditionally removes the antd.js fixture from test runs when process.env.CI is set
  • Simplifies the "range & parent" test configuration by removing the previous filtering logic
  • Removes unused import sep as pathSep since it's no longer needed

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits, feel free to ignore

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 8, 2025
Copy link
Member Author

overlookmotel commented Oct 8, 2025

Merge activity

…14446)

The raw transfer test on `antd.js` fixture is timing out sometimes on CI. We already disabled the "range & parent" test on this fixture. Disable the other test on it too. But only skip these tests in CI.

(alternative to #14438)
@graphite-app graphite-app bot force-pushed the 10-08-test_napi_parser_disable_raw_transfer_tests_on_antd.js_fixture branch from a55d4ed to f293e3e Compare October 8, 2025 17:43
@graphite-app graphite-app bot merged commit f293e3e into main Oct 8, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 10-08-test_napi_parser_disable_raw_transfer_tests_on_antd.js_fixture branch October 8, 2025 17:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants