Skip to content

Conversation

@holoflash
Copy link
Contributor

Issue

Passing an empty string to additionalHooks in the react-hooks/exhaustive-deps rule:
"react-hooks/exhaustive-deps": ["error", { "additionalHooks": "" }],
causes the linter to consider all functions to be additionalHooks.

Behaviour in ESLint

Passing an empty string doesn't do anything.
Passing "()" causes the same problematic behaviour:
"react-hooks/exhaustive-deps": ["warn", { additionalHooks: "()" }],
The same is true for oxlint.

Suggested fix

Check for empty string.
Since ESLint is able to take an empty string without breaking - so should oxlint.
Ideally - handle the "()" case too, or leave it as is to match original behaviour.

How to test

Add:
"react-hooks/exhaustive-deps": ["error", { "additionalHooks": "" }],
to your .oxlintrc.json file
Lint the codebase.

Example:

function MyComponent(props) {
          const foo = bar.add();
    }
  ⚠ eslint-plugin-react-hooks(exhaustive-deps): React hook add requires an effect callback.
   ╭─[exhaustive_deps.tsx:2:23]
 1 │ function MyComponent(props) {
 2 │           const foo = bar.add();
   ·                       ─────────
 3 │         }
   ╰────
  help: Did you forget to pass a callback to the hook?

-------- rule config --------
[
  {
    "additionalHooks": ""
  }
]

@holoflash holoflash requested a review from camc314 as a code owner October 9, 2025 17:20
Copilot AI review requested due to automatic review settings October 9, 2025 17:20
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the react-hooks/exhaustive-deps linter rule where passing an empty string to the additionalHooks configuration causes all functions to be incorrectly treated as additional hooks. The fix adds validation to filter out empty strings before regex compilation.

  • Adds empty string filtering to prevent incorrect regex matching behavior
  • Includes a test case to verify the fix works correctly

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the A-linter Area - Linter label Oct 9, 2025
@holoflash holoflash changed the title bug(linter): exhaustive-deps additionalHooks empty string fix(linter): exhaustive-deps additionalHooks empty string Oct 9, 2025
@github-actions github-actions bot added the C-bug Category - Bug label Oct 9, 2025
@camc314 camc314 self-assigned this Oct 12, 2025
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 changed the title fix(linter): exhaustive-deps additionalHooks empty string fix(linter/exhaustive-deps): ignore empty strings passed to additionalHooks option Oct 12, 2025
@camc314 camc314 merged commit 9965676 into oxc-project:main Oct 12, 2025
21 of 22 checks passed
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 12, 2025

CodSpeed Performance Report

Merging #14464 will not alter performance

Comparing holoflash:bug/exhaustive-deps-additionalHooks (65969cc) with main (0f19be0)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@holoflash holoflash deleted the bug/exhaustive-deps-additionalHooks branch October 12, 2025 19:24
camc314 added a commit that referenced this pull request Oct 13, 2025
## [1.23.0] - 2025-10-13

### 🚀 Features

- 452d128 linter: Node/no_process_env (#14536) (Kenneth Skovhus)
- a9e1261 linter: Implement react-refresh/only-export-components
(#14122) (Rintaro Itokawa)
- a8d542b linter/no-duplicate-imports: Support
`allowSeparateTypeImports` option (#14527) (camc314)
- 75a529c linter: Add run info about what functions rules implement
(#13839) (camchenry)
- 4fbdef2 language_server: Support `fmt.configPath` configuration
(#14502) (Sysix)
- 4d3ce2e language_server: Autodetect root `.oxfmtrc.json` (#14466)
(Sysix)

### 🐛 Bug Fixes

- fb4a20d language_server: Add whitespace for `//
oxlint-disable-next-line` fix (#14356) (Sysix)
- 6fce7f4 oxlint/changelog: Remove duplicate changelog entries (#14528)
(camc314)
- 74e52f3 linter/plugins: Resolve JS plugins with ESM condition names
(#14541) (magic-akari)
- 9965676 linter/exhaustive-deps: Ignore empty strings passed to
`additionalHooks` option (#14464) (Redas)
- d0a8e3e linter: `vue/no_required_prop_with_default` called
`Option::unwrap()` on a `None` value (#14491) (Sysix)
- 1192ea2 linter: Correct `nextjs/no-typos` path handling (#14480)
(shulaoda)
- 2796b16 tsgolint: Pipe tsgolints stderr (#14477) (camc314)

### 🚜 Refactor

- 6440cde linter: Remove lifetime of `Message` (#14481) (Sysix)
- f599bef language_server: Move `Message` to `DiagnosticReport`
transformation to one place (#14447) (Sysix)
- 4f301de napi/parser, linter/plugins: Improve formatting of generated
code (#14554) (overlookmotel)
- 68c0252 napi/parser, linter/plugins: Shorten generated raw transfer
deserializer code (#14553) (overlookmotel)
- 20e884e linter: Store `LintService` in `LintRunner` (#14471) (Sysix)
- 9e9c5ba linter: Simplify built-in lint plugin checks (#14518)
(camchenry)
- 1986e0f linter/no-ex-assign: Use let-else chain (#14526) (camc314)
- ce9bcf0 linter/no-func-assign: Use let-else chain (#14525) (camc314)
- a9cea7c language_server: Use `FxHashSet` for
`ServerLinter::extended_paths` (#14517) (Sysix)
- ea5838e linter/no-import-assign: Use let-else chain (#14524) (camc314)
- f977700 language_server: Pass `LintOptions` to
`Worker::refresh_server_linter` (#14510) (Sysix)
- 54b001f linter/no-new-require: Improve diagnostic message clarity
(#14511) (shulaoda)
- 650ea68 linter: Improve nextjs/no-typos rule (#14476) (shulaoda)

### 📚 Documentation

- 198f2e9 linter: Fix code example for `branches-sharing-code` (#14514)
(camc314)
- d776a17 linter: Improve `nextjs/no-typos` rule documentation (#14470)
(shulaoda)

### ⚡ Performance

- b44a30e language_server: Transform `Message` to `DiagnosticReport`
with one call (#14448) (Sysix)
- 31766fd linter/plugins: Provide `loc` via prototype (#14552)
(overlookmotel)
- aec0c08 linter: Allow analyzing node types in match blocks with guards
(#14459) (camchenry)
- 9044187 linter: Skip running node-specific rule if file contains no
relevant nodes (#14457) (camchenry)
- 422f54e linter: Only run rule run functions if implemented (#14454)
(camchenry)
- 2c228ae liner: Use top-level match for `no_obj_calls` (#14523)
(camchenry)
- c49d891 linter: Use match for `no_negated_condition` (#14522)
(camchenry)
- e222fc2 linter: Use match for `no_multi_assign` (#14521) (camchenry)
- 4440516 linter: Refactor rules to take advantage of node type skipping
(#14519) (camchenry)
- 78261d6 linter: Refactor `no-invalid-fetch-options` to be more easily
analyzed (#14458) (camchenry)

### 🧪 Testing

- 8d8881d linter/plugins: Expand tests for module resolution of plugins
(#14559) (overlookmotel)
- 33b6cde language_server: Add basic tests for
`WorkspaceWorker::did_change_configuration` (#14531) (Sysix)
- bfe1ecd language_server: Add tests for
`WorkspaceWorker::init_watchers` (#14516) (Sysix)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants