fix(oxlint,oxfmt): Skip traversing `.git` directories #14590

Boshen · 2025-10-14T09:20:35Z

fixes #13315

.git is not a special case for .hidden(false).

See BurntSushi/ripgrep#3099 (comment)

Only tested this manually, can't really create a reproduction ...

Boshen · 2025-10-14T09:20:53Z

fix(oxlint,oxfmt): Skip traversing .git directories #14590 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR adds explicit handling to skip traversing .git directories in both oxlint and oxfmt tools, addressing issue #13315 where .git directories were being unnecessarily traversed since they're not covered by the .hidden(false) configuration.

Added explicit .git directory detection and skipping logic
Refactored conditional structure in oxfmt for better readability
Both tools now avoid performance overhead of traversing version control directories

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
apps/oxlint/src/walk.rs	Added `.git` directory skip logic in `is_wanted_entry` function
apps/oxfmt/src/walk.rs	Refactored directory handling and added `.git` skip logic with proper `WalkState::Skip` return

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

apps/oxlint/src/walk.rs

Boshen · 2025-10-14T12:28:18Z

Merge activity

Oct 14, 12:28 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 14, 12:32 PM UTC: Boshen added this pull request to the Graphite merge queue.
Oct 14, 12:38 PM UTC: Merged by the Graphite merge queue.

fixes #13315 `.git` is not a special case for `.hidden(false)`. See BurntSushi/ripgrep#3099 (comment) Only tested this manually, can't really create a reproduction ...

## [0.6.0] - 2025-10-20 ### 🚀 Features - 7f91a26 oxfmt: Handle ignoring files (#14798) (leaysgur) - 199a2c6 oxfmt: Support `--with-node-modules` option (#14713) (leaysgur) - 6bf8bac formatter: Reimplement formatting for `ImportExpression` (#14712) (Dunqing) - 3f2e036 formatter: Introduce `AstNode<ExpressionStatement>::is_arrow_function_body` (#14709) (Dunqing) - df225e9 formatter: Add `AstNode::ancestor` and `AstNode::grand_parent` methods (#14700) (Dunqing) - 26c5f5a oxfmt: Ignore VCS directories by default (#14616) (leaysgur) - fec2ed9 oxfmt: Use Prettier style config key and value (#14612) (leaysgur) - 1b58521 oxfmt,language_server: Enable JSX for all JS source type (#14605) (leaysgur) ### 🐛 Bug Fixes - 21c4285 formatter: Correct printing remaining trailing comments for `TSMappedType` (#14761) (Dunqing) - 1d1573e formatter: Correct adding semicolons for TypeScript left-hand side nodes (#14760) (Dunqing) - 4cc3b10 formatter: Improve handling of new lines between comments in `MemberChain` (#14759) (Dunqing) - e6bce8e formatter: Break the left hand side of AssignmentLike node if it is an `ObjectPattern` with three properties (#14756) (Dunqing) - dc57a2b formatter: Incorrect handling of `VariableDeclarator` with an `ArrowFunctionExpression` initializer (#14731) (Dunqing) - 537185d formatter: Should always group the left side of `AssignmentPattern` (#14730) (Dunqing) - ef02760 oxfmt: Handle relative path starts with dot (#14708) (leaysgur) - ee37f5d oxfmt: Handle default cwd correctly (#14704) (leaysgur) - 4283fd8 formatter: Correct printing comments for `JSXAttributeValue` (#14719) (Dunqing) - 59c9e1b formatter: Avoid conditional being broken in arguments by trailing comments (#14718) (Dunqing) - 7d64b96 formatter: Should wrap parentheses with JSX arguments of `NewExpression` (#14717) (Dunqing) - 2068a63 formatter: Should indent TemplateExpression if it is a member expression that is part of `ChainExpression` (#14714) (Dunqing) - 5ea3bb6 formatter: Incorrect handling of `ObjectPattern` as an `AssignmentPattern` of a parameter (#14711) (Dunqing) - eb52529 formatter: Incorrect handling of `ObjectPattern` as a parameter (#14670) (Dunqing) - 8ac10da formatter: Correct checking assignment layout for the right side with ownline comment and it is a `PrivateFieldExpression` (#14664) (Dunqing) - 6cba9b1 formatter: Should not merge tail with head for MemberChain when its parent is ArrowFunctionExpression (#14663) (Dunqing) - f44d3c0 formatter: Should not indent BinaryLikeExpression when its parent is `NewExpression` (#14662) (Dunqing) - bf953b8 formatter: Should group nested test for TSConditionalType (#14661) (Dunqing) - 63dc57b formatter: Correct handling if a template literal should be printed as a signle line (#14660) (Dunqing) - 0150ad5 formatter: Should group type parameters and parameters for method-like and function-like nodes (#14659) (Dunqing) - 392bf74 formatter: Improve handling of dangling comments in if statements (#14658) (Dunqing) - fd52b10 formatter: Don't print CallExpression as MemberChain style when its only has one argument and it is a TemplateLiteral on its own line (#14657) (Dunqing) - 29c3c60 formatter: Don't group nested await expression when its is the leftmost expression (#14656) (Dunqing) - 72c7503 formatter: Correct checking function composition when the arguments have an call expression before function (#14655) (Dunqing) - 2b645e2 formatter: Don't wrap parenthesis for `type` when its grandparent isn't a `ExpressionStatement` (#14654) (Dunqing) - e0eb966 formatter: Skip the leading semicolon when calculating leading lines (#14653) (Dunqing) - 0961c3a oxlint,oxfmt: Skip traversing `.git` directories (#14590) (Boshen) ### 🚜 Refactor - b7926f3 oxfmt: Update CLI --help details (#14796) (leaysgur) - 173168b oxfmt: Refactor walk.rs and format.rs relationship (#14795) (leaysgur) - aea9d79 oxfmt: Pass `PathBuf` from walk.rs to service.rs (#14716) (leaysgur) - 83e783a formatter: Organize utils structure (#14710) (Dunqing) - 58dd74a formatter: Remove all `without_parentheses` usages (#14707) (Dunqing) - 75dfcad formatter: Simplify `ExpressionLeftSide` (#14706) (Dunqing) - 273f0fe formatter: Remove unnecessary lifetimes for the implementations of `NeedsParentheses` (#14703) (Dunqing) - bae5f11 formatter: Improve `AstNode` and `AstNodes` (#14686) (Dunqing) ### ⚡ Performance - c6395c7 formatter: Optimize string reservation in print_text (#14751) (Boshen) ### 🧪 Testing - 7c42ea0 oxfmt: Remove args from snapshot file name (#14800) (leaysgur) - 42d8c62 formatter: Add tests for sort-imports (#14685) (leaysgur)

Copilot AI review requested due to automatic review settings October 14, 2025 09:20

Boshen requested a review from camc314 as a code owner October 14, 2025 09:20

Copilot AI reviewed Oct 14, 2025

View reviewed changes

apps/oxlint/src/walk.rs Outdated Show resolved Hide resolved

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-formatter Area - Formatter labels Oct 14, 2025

Boshen requested a review from leaysgur October 14, 2025 09:20

github-actions bot added the C-bug Category - Bug label Oct 14, 2025

Boshen force-pushed the 10-14-fix_oxlint_oxfmt_skip_traversing_.git_directories branch from d6ba1a5 to 876b3f7 Compare October 14, 2025 09:35

leaysgur approved these changes Oct 14, 2025

View reviewed changes

Boshen self-assigned this Oct 14, 2025

Boshen force-pushed the 10-14-fix_oxlint_oxfmt_skip_traversing_.git_directories branch from 876b3f7 to f17ccbb Compare October 14, 2025 12:25

Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 14, 2025

fix(oxlint,oxfmt): Skip traversing .git directories (#14590)

0961c3a

fixes #13315 `.git` is not a special case for `.hidden(false)`. See BurntSushi/ripgrep#3099 (comment) Only tested this manually, can't really create a reproduction ...

graphite-app bot force-pushed the 10-14-fix_oxlint_oxfmt_skip_traversing_.git_directories branch from f17ccbb to 0961c3a Compare October 14, 2025 12:33

graphite-app bot merged commit 0961c3a into main Oct 14, 2025
18 checks passed

graphite-app bot deleted the 10-14-fix_oxlint_oxfmt_skip_traversing_.git_directories branch October 14, 2025 12:38

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 14, 2025

Boshen mentioned this pull request Oct 20, 2025

release(oxfmt): v0.6.0 #14804

Merged

Boshen mentioned this pull request Oct 22, 2025

release(oxlint): v1.24.0 #14893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(oxlint,oxfmt): Skip traversing `.git` directories #14590

fix(oxlint,oxfmt): Skip traversing `.git` directories #14590

Uh oh!

Boshen commented Oct 14, 2025

Uh oh!

Boshen commented Oct 14, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Boshen commented Oct 14, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(oxlint,oxfmt): Skip traversing .git directories #14590

fix(oxlint,oxfmt): Skip traversing .git directories #14590

Uh oh!

Conversation

Boshen commented Oct 14, 2025

Uh oh!

Boshen commented Oct 14, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Boshen commented Oct 14, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(oxlint,oxfmt): Skip traversing `.git` directories #14590

fix(oxlint,oxfmt): Skip traversing `.git` directories #14590

Boshen commented Oct 14, 2025 •

edited by graphite-app bot

Loading