feat(oxfmt): Support `--with-node-modules` option #14713

leaysgur · 2025-10-17T07:30:16Z

https://prettier.io/docs/cli#--with-node-modules

leaysgur · 2025-10-17T07:30:35Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

graphite-app · 2025-10-20T07:57:39Z

Merge activity

Oct 20, 7:57 AM UTC: Dunqing added this pull request to the Graphite merge queue.
Oct 20, 8:03 AM UTC: Merged by the Graphite merge queue.

Part of #13743 https://prettier.io/docs/cli#--with-node-modules

## [0.6.0] - 2025-10-20 ### 🚀 Features - 7f91a26 oxfmt: Handle ignoring files (#14798) (leaysgur) - 199a2c6 oxfmt: Support `--with-node-modules` option (#14713) (leaysgur) - 6bf8bac formatter: Reimplement formatting for `ImportExpression` (#14712) (Dunqing) - 3f2e036 formatter: Introduce `AstNode<ExpressionStatement>::is_arrow_function_body` (#14709) (Dunqing) - df225e9 formatter: Add `AstNode::ancestor` and `AstNode::grand_parent` methods (#14700) (Dunqing) - 26c5f5a oxfmt: Ignore VCS directories by default (#14616) (leaysgur) - fec2ed9 oxfmt: Use Prettier style config key and value (#14612) (leaysgur) - 1b58521 oxfmt,language_server: Enable JSX for all JS source type (#14605) (leaysgur) ### 🐛 Bug Fixes - 21c4285 formatter: Correct printing remaining trailing comments for `TSMappedType` (#14761) (Dunqing) - 1d1573e formatter: Correct adding semicolons for TypeScript left-hand side nodes (#14760) (Dunqing) - 4cc3b10 formatter: Improve handling of new lines between comments in `MemberChain` (#14759) (Dunqing) - e6bce8e formatter: Break the left hand side of AssignmentLike node if it is an `ObjectPattern` with three properties (#14756) (Dunqing) - dc57a2b formatter: Incorrect handling of `VariableDeclarator` with an `ArrowFunctionExpression` initializer (#14731) (Dunqing) - 537185d formatter: Should always group the left side of `AssignmentPattern` (#14730) (Dunqing) - ef02760 oxfmt: Handle relative path starts with dot (#14708) (leaysgur) - ee37f5d oxfmt: Handle default cwd correctly (#14704) (leaysgur) - 4283fd8 formatter: Correct printing comments for `JSXAttributeValue` (#14719) (Dunqing) - 59c9e1b formatter: Avoid conditional being broken in arguments by trailing comments (#14718) (Dunqing) - 7d64b96 formatter: Should wrap parentheses with JSX arguments of `NewExpression` (#14717) (Dunqing) - 2068a63 formatter: Should indent TemplateExpression if it is a member expression that is part of `ChainExpression` (#14714) (Dunqing) - 5ea3bb6 formatter: Incorrect handling of `ObjectPattern` as an `AssignmentPattern` of a parameter (#14711) (Dunqing) - eb52529 formatter: Incorrect handling of `ObjectPattern` as a parameter (#14670) (Dunqing) - 8ac10da formatter: Correct checking assignment layout for the right side with ownline comment and it is a `PrivateFieldExpression` (#14664) (Dunqing) - 6cba9b1 formatter: Should not merge tail with head for MemberChain when its parent is ArrowFunctionExpression (#14663) (Dunqing) - f44d3c0 formatter: Should not indent BinaryLikeExpression when its parent is `NewExpression` (#14662) (Dunqing) - bf953b8 formatter: Should group nested test for TSConditionalType (#14661) (Dunqing) - 63dc57b formatter: Correct handling if a template literal should be printed as a signle line (#14660) (Dunqing) - 0150ad5 formatter: Should group type parameters and parameters for method-like and function-like nodes (#14659) (Dunqing) - 392bf74 formatter: Improve handling of dangling comments in if statements (#14658) (Dunqing) - fd52b10 formatter: Don't print CallExpression as MemberChain style when its only has one argument and it is a TemplateLiteral on its own line (#14657) (Dunqing) - 29c3c60 formatter: Don't group nested await expression when its is the leftmost expression (#14656) (Dunqing) - 72c7503 formatter: Correct checking function composition when the arguments have an call expression before function (#14655) (Dunqing) - 2b645e2 formatter: Don't wrap parenthesis for `type` when its grandparent isn't a `ExpressionStatement` (#14654) (Dunqing) - e0eb966 formatter: Skip the leading semicolon when calculating leading lines (#14653) (Dunqing) - 0961c3a oxlint,oxfmt: Skip traversing `.git` directories (#14590) (Boshen) ### 🚜 Refactor - b7926f3 oxfmt: Update CLI --help details (#14796) (leaysgur) - 173168b oxfmt: Refactor walk.rs and format.rs relationship (#14795) (leaysgur) - aea9d79 oxfmt: Pass `PathBuf` from walk.rs to service.rs (#14716) (leaysgur) - 83e783a formatter: Organize utils structure (#14710) (Dunqing) - 58dd74a formatter: Remove all `without_parentheses` usages (#14707) (Dunqing) - 75dfcad formatter: Simplify `ExpressionLeftSide` (#14706) (Dunqing) - 273f0fe formatter: Remove unnecessary lifetimes for the implementations of `NeedsParentheses` (#14703) (Dunqing) - bae5f11 formatter: Improve `AstNode` and `AstNodes` (#14686) (Dunqing) ### ⚡ Performance - c6395c7 formatter: Optimize string reservation in print_text (#14751) (Boshen) ### 🧪 Testing - 7c42ea0 oxfmt: Remove args from snapshot file name (#14800) (leaysgur) - 42d8c62 formatter: Add tests for sort-imports (#14685) (leaysgur)

leaysgur mentioned this pull request Oct 17, 2025

fix(oxfmt): Handle default cwd correctly #14704

Merged

github-actions bot added A-cli Area - CLI A-formatter Area - Formatter labels Oct 17, 2025

github-actions bot added the C-enhancement Category - New feature or request label Oct 17, 2025

leaysgur mentioned this pull request Oct 17, 2025

fix(oxfmt): Handle relative path starts with dot #14708

Merged

leaysgur force-pushed the 10-17-feat_oxfmt_support_--with-node-modules_option branch from 1475aaf to 346fa80 Compare October 17, 2025 07:43

leaysgur assigned Dunqing Oct 17, 2025

leaysgur changed the title ~~feat(oxfmt): Support --with-node-modules option~~ feat(oxfmt): Support --with-node-modules option Oct 17, 2025

leaysgur force-pushed the 10-17-feat_oxfmt_support_--with-node-modules_option branch from 346fa80 to 0690c81 Compare October 17, 2025 08:15

leaysgur force-pushed the 10-17-fix_oxfmt_handle_relative_path_starts_with_dot branch from f6590ec to 28c50a7 Compare October 17, 2025 08:15

leaysgur mentioned this pull request Oct 17, 2025

refactor(oxfmt): Pass PathBuf from walk.rs to service.rs #14716

Merged

leaysgur force-pushed the 10-17-fix_oxfmt_handle_relative_path_starts_with_dot branch from 28c50a7 to f4c79cd Compare October 17, 2025 10:11

leaysgur force-pushed the 10-17-feat_oxfmt_support_--with-node-modules_option branch from 0690c81 to 9617bca Compare October 17, 2025 10:11

graphite-app bot changed the base branch from 10-17-fix_oxfmt_handle_relative_path_starts_with_dot to graphite-base/14713 October 20, 2025 01:02

graphite-app bot force-pushed the 10-17-feat_oxfmt_support_--with-node-modules_option branch from 9617bca to 77b38d8 Compare October 20, 2025 01:08

graphite-app bot force-pushed the graphite-base/14713 branch from f4c79cd to ef02760 Compare October 20, 2025 01:08

leaysgur force-pushed the 10-17-feat_oxfmt_support_--with-node-modules_option branch from 77b38d8 to f5fd194 Compare October 20, 2025 01:08

leaysgur changed the base branch from graphite-base/14713 to main October 20, 2025 01:08

graphite-app bot force-pushed the 10-17-feat_oxfmt_support_--with-node-modules_option branch from f5fd194 to 37a07d5 Compare October 20, 2025 01:08

Copilot AI review requested due to automatic review settings October 20, 2025 01:08

Copilot AI reviewed Oct 20, 2025

View reviewed changes

leaysgur force-pushed the 10-17-feat_oxfmt_support_--with-node-modules_option branch from 37a07d5 to de7588d Compare October 20, 2025 04:12

leaysgur mentioned this pull request Oct 20, 2025

refactor(oxfmt): Refactor walk.rs and format.rs relationship #14795

Merged

leaysgur force-pushed the 10-17-feat_oxfmt_support_--with-node-modules_option branch from de7588d to 9e7a257 Compare October 20, 2025 04:20

This was referenced Oct 20, 2025

refactor(oxfmt): Update CLI --help details #14796

Merged

feat(oxfmt): Handle ignoring files #14798

Merged

leaysgur force-pushed the 10-17-feat_oxfmt_support_--with-node-modules_option branch from 9e7a257 to 679dd75 Compare October 20, 2025 05:31

leaysgur mentioned this pull request Oct 20, 2025

test(oxfmt): Remove args from snapshot file name #14800

Merged

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 20, 2025

feat(oxfmt): Support --with-node-modules option (#14713)

199a2c6

Part of #13743 https://prettier.io/docs/cli#--with-node-modules

graphite-app bot force-pushed the 10-17-feat_oxfmt_support_--with-node-modules_option branch from 679dd75 to 199a2c6 Compare October 20, 2025 07:58

graphite-app bot merged commit 199a2c6 into main Oct 20, 2025
18 checks passed

graphite-app bot deleted the 10-17-feat_oxfmt_support_--with-node-modules_option branch October 20, 2025 08:03

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 20, 2025

Boshen mentioned this pull request Oct 20, 2025

release(oxfmt): v0.6.0 #14804

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(oxfmt): Support `--with-node-modules` option #14713

feat(oxfmt): Support `--with-node-modules` option #14713

Uh oh!

leaysgur commented Oct 17, 2025 •

edited

Loading

Uh oh!

leaysgur commented Oct 17, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(oxfmt): Support --with-node-modules option #14713

feat(oxfmt): Support --with-node-modules option #14713

Uh oh!

Conversation

leaysgur commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaysgur commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(oxfmt): Support `--with-node-modules` option #14713

feat(oxfmt): Support `--with-node-modules` option #14713

leaysgur commented Oct 17, 2025 •

edited

Loading

leaysgur commented Oct 17, 2025 •

edited

Loading

graphite-app bot commented Oct 20, 2025 •

edited

Loading