Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 16, 2025

fixes #14675

@github-actions github-actions bot added the A-linter Area - Linter label Oct 16, 2025
Copy link
Contributor Author

camc314 commented Oct 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Oct 16, 2025
@camc314 camc314 marked this pull request as ready for review October 16, 2025 15:49
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 16, 2025

CodSpeed Performance Report

Merging #14674 will not alter performance

Comparing c/10-16-test_linter_add_test_case_with_function_params_in_no-const-assign (5aed258) with c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents (937f768)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 force-pushed the c/10-16-test_linter_add_test_case_with_function_params_in_no-const-assign branch from 60790f5 to a1fd4ef Compare October 16, 2025 15:55
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from df96c3f to 31b646b Compare October 16, 2025 15:55
@camc314 camc314 force-pushed the c/10-16-test_linter_add_test_case_with_function_params_in_no-const-assign branch from a1fd4ef to f1b4de7 Compare October 16, 2025 15:57
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 31b646b to cddb43e Compare October 16, 2025 15:57
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 16, 2025
Copy link
Member

Dunqing commented Oct 16, 2025

Merge activity

@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from cddb43e to 937f768 Compare October 16, 2025 16:04
@camc314 camc314 force-pushed the c/10-16-test_linter_add_test_case_with_function_params_in_no-const-assign branch 2 times, most recently from 5aed258 to a2c20c5 Compare October 16, 2025 16:10
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 937f768 to f4beec1 Compare October 16, 2025 16:10
@camc314 camc314 force-pushed the c/10-16-test_linter_add_test_case_with_function_params_in_no-const-assign branch from a2c20c5 to ade0951 Compare October 16, 2025 16:17
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch 2 times, most recently from 7532224 to 2df531b Compare October 16, 2025 16:24
@camc314 camc314 force-pushed the c/10-16-test_linter_add_test_case_with_function_params_in_no-const-assign branch from ade0951 to 4bb8552 Compare October 16, 2025 16:24
@graphite-app graphite-app bot force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 2df531b to 2fd9e45 Compare October 17, 2025 02:06
@graphite-app graphite-app bot requested a review from overlookmotel as a code owner October 17, 2025 02:06
@graphite-app graphite-app bot force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 2fd9e45 to 3a835b4 Compare October 17, 2025 02:07
@graphite-app graphite-app bot force-pushed the c/10-16-test_linter_add_test_case_with_function_params_in_no-const-assign branch from 4bb8552 to 7245365 Compare October 17, 2025 02:07
@graphite-app graphite-app bot force-pushed the c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents branch from 3a835b4 to ae2003c Compare October 17, 2025 04:30
@graphite-app graphite-app bot force-pushed the c/10-16-test_linter_add_test_case_with_function_params_in_no-const-assign branch from 7245365 to cd9ef3e Compare October 17, 2025 04:31
Base automatically changed from c/10-16-feat_semantic_add_symbol_id_to_ts_function_type_binding_idents to main October 17, 2025 04:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 17, 2025
@graphite-app graphite-app bot merged commit cd9ef3e into main Oct 17, 2025
21 checks passed
@graphite-app graphite-app bot deleted the c/10-16-test_linter_add_test_case_with_function_params_in_no-const-assign branch October 17, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option::unwrap() on a None value

3 participants