Skip to content

perf(language_server): avoid creating HashMap in Backend::did_change_configuration #14736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

perf(language_server): avoid creating HashMap in Backend::did_change_configuration #14736

merged 1 commit into from
Oct 17, 2025

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Oct 17, 2025

No description provided.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 17, 2025
@Sysix Sysix mentioned this pull request Oct 17, 2025
Merged
@Sysix Graphite App
Copy link
Member Author

Sysix commented Oct 17, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix mentioned this pull request Oct 17, 2025
Merged
@Sysix Sysix force-pushed the 10-17-perf_language_server_avoid_greating_hashmap_in_backend_did_change_watched_files_ branch from 5279f46 to ebd1d74 Compare October 17, 2025 18:57
@Sysix Sysix force-pushed the 10-17-perf_language_server_avoid_greating_hashmap_in_backend_did_change_configuration_ branch from a4ccb66 to 4ba6930 Compare October 17, 2025 18:57
@Sysix Sysix force-pushed the 10-17-perf_language_server_avoid_greating_hashmap_in_backend_did_change_watched_files_ branch from ebd1d74 to 8ad2256 Compare October 17, 2025 19:15
@Sysix Sysix force-pushed the 10-17-perf_language_server_avoid_greating_hashmap_in_backend_did_change_configuration_ branch from 4ba6930 to 9b59141 Compare October 17, 2025 19:15
@Sysix Sysix changed the title perf(language_server): avoid greating HashMap in Backend::did_change_configuration perf(language_server): avoid gcreating HashMap in Backend::did_change_configuration Oct 17, 2025
@Sysix Sysix changed the title perf(language_server): avoid gcreating HashMap in Backend::did_change_configuration perf(language_server): avoid creating HashMap in Backend::did_change_configuration Oct 17, 2025
@Sysix Sysix marked this pull request as ready for review October 17, 2025 19:23
@Sysix Sysix requested a review from camc314 as a code owner October 17, 2025 19:23
@Sysix Sysix mentioned this pull request Oct 17, 2025
Merged
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 17, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Oct 17, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot changed the base branch from 10-17-perf_language_server_avoid_greating_hashmap_in_backend_did_change_watched_files_ to graphite-base/14736 October 17, 2025 19:50
@graphite-app graphite-app bot changed the base branch from graphite-base/14736 to main October 17, 2025 19:53
@graphite-app graphite-app bot force-pushed the 10-17-perf_language_server_avoid_greating_hashmap_in_backend_did_change_configuration_ branch from 9b59141 to 22ee19f Compare October 17, 2025 19:54
@graphite-app graphite-app bot merged commit 22ee19f into main Oct 17, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-17-perf_language_server_avoid_greating_hashmap_in_backend_did_change_configuration_ branch October 17, 2025 19:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 17, 2025
@Boshen Boshen mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sysix @camc314