perf(language_server): return Diagnostic when relinting all files
#14737
+18
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-editor
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the language server’s relinting path by returning lightweight LSP Diagnostics instead of DiagnosticReport entries that include PossibleFixContent, which is unnecessary for relinting triggered by configuration changes.
- Change revalidate_diagnostics to return Vec<(String, Vec)> instead of ConcurrentHashMap<String, Vec>
- Update callers to handle the new return type without cloning Diagnostic values
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| crates/oxc_language_server/src/worker.rs | Adjusted method signatures and return types to use Vec<(String, Vec)> and removed ConcurrentHashMap usage. |
| crates/oxc_language_server/src/linter/server_linter.rs | Rewrote revalidate_diagnostics to build Vec<(String, Vec)> and map DiagnosticReport to Diagnostic. |
| crates/oxc_language_server/src/backend.rs | Simplified aggregation by extending vectors directly, avoiding Diagnostic clones. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
graphite-app
bot
changed the base branch from
10-17-perf_language_server_avoid_greating_hashmap_in_backend_did_change_configuration_
to
graphite-base/14737
graphite-app
bot
force-pushed
the
graphite-base/14737
branch
from
9b59141 to
22ee19f
Compare
graphite-app
bot
force-pushed
the
10-17-perf_language_server_return_diagnostic_when_relinting_all_files
branch
from
6df681a to
90402d5
Compare
graphite-app
bot
force-pushed
the
10-17-perf_language_server_return_diagnostic_when_relinting_all_files
branch
from
90402d5 to
26ca6a2
Compare
Sysix
force-pushed
the
10-17-perf_language_server_return_diagnostic_when_relinting_all_files
branch
from
26ca6a2 to
3f7a0fc
Compare
camc314
approved these changes
Oct 17, 2025
Contributor
Merge activity
|
…14737) When relinting the files, the `PossibleFixContent` is not relevant for the processes. These are: - changing language server configuration - changing oxlint configuration
graphite-app
bot
force-pushed
the
10-17-perf_language_server_return_diagnostic_when_relinting_all_files
branch
from
3f7a0fc to
df48416
Compare
graphite-app
bot
deleted the
10-17-perf_language_server_return_diagnostic_when_relinting_all_files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When relinting the files, the
PossibleFixContentis not relevant for the processes.These are: