feat(language_server): Search both .json and .jsonc config file #14868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-editor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the language server's config file handling to search for both .oxfmtrc.json and .oxfmtrc.jsonc files, matching the behavior implemented in the CLI.
Key Changes
- Changed
FORMAT_CONFIG_FILEconstant from a single string toFORMAT_CONFIG_FILESarray containing both.jsonand.jsoncextensions - Refactored file search logic to check multiple config file patterns
- Updated file watcher registration to monitor both config file types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_language_server/src/main.rs | Changed format config constant from single string to array of file extensions |
| crates/oxc_language_server/src/formatter/server_formatter.rs | Refactored config file search logic and updated watcher pattern methods to handle multiple file types |
| crates/oxc_language_server/src/worker.rs | Updated file watcher registration code to iterate over multiple patterns and updated tests to verify both file types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sysix
force-pushed
the
10-21-feat_language_server_search_both_.json_and_.jsonc_config_file
branch
from
1c8cb9e to
cf009a3
Compare
camc314
approved these changes
Oct 22, 2025
Merge activity
|
The same as the CLI is now doing it: #14848
graphite-app
bot
force-pushed
the
10-21-feat_language_server_search_both_.json_and_.jsonc_config_file
branch
from
cf009a3 to
e3d65c3
Compare
graphite-app
bot
deleted the
10-21-feat_language_server_search_both_.json_and_.jsonc_config_file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as the CLI is now doing it: #14848