feat(oxfmt): Search both .json and .jsonc config file #14848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for .oxfmtrc.jsonc configuration files in oxfmt, with .json files taking priority when both formats exist in the same directory. The configuration file discovery logic now searches for both file types during upward directory traversal.
Key Changes:
- Extended config file search to support both
.jsonand.jsoncextensions - Established priority where
.jsontakes precedence over.jsonc - Added test fixture to verify the priority behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxfmt/src/format.rs | Modified config discovery to iterate through both .json and .jsonc filenames with priority ordering |
| apps/oxfmt/tests/mod.rs | Added documentation explaining the test validates .json priority over .jsonc |
| apps/oxfmt/tests/fixtures/config_file/.oxfmtrc.jsonc | Added test fixture with semi: false to contrast with existing .json file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-cli
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
10-21-feat_oxfmt_search_both_.json_and_.jsonc_config_file
branch
from
5e9bee9 to
6dfcd80
Compare
graphite-app
bot
deleted the
10-21-feat_oxfmt_search_both_.json_and_.jsonc_config_file
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
## [0.7.0] - 2025-10-21 ### 🚀 Features - 6dfcd80 oxfmt: Search both .json and .jsonc config file (#14848) (leaysgur) - aa024d9 formatter: Wrap parenthesis for `AssignmentExpression` that are inside `ComputedMemberExpression` (#14834) (Dunqing) ### 🐛 Bug Fixes - 88fb768 formatter: Correct handling of ignore comment for `TSUnionType` and `TSMappedType` (#14824) (Dunqing) - f7727c7 formatter: Ignore comment doesn't work for the expression statement (#14817) (Dunqing) - 7a420a1 oxfmt: Handle `.d.ts` file correctly (#14835) (leaysgur) ### 🚜 Refactor - 6fa7420 oxfmt: Use custom ignore builder (#14850) (leaysgur) - 9d914a3 formatter: Improve comments handling (#14816) (Dunqing) - f52863d formatter: Improve handling of type cast node (#14815) (Dunqing)
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
The same as the CLI is now doing it: #14848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14575