refactor(formatter): improve handling of type cast node

[Dunqing]

No description provided.

[Dunqing]

• feat(formatter): wrap parenthesis for AssignmentExpression that are inside ComputedMemberExpression #14834
• fix(formatter): correct handling of ignore comment for TSUnionType and TSMappedType #14824
• fix(formatter): ignore comment doesn't work for the expression statement #14817
• refactor(formatter): improve comments handling #14816
• refactor(formatter): improve handling of type cast node #14815 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #14815 will not alter performance

_{Comparing 10-20-refactor_formatter_improve_handling_of_type_cast_node (f2c0f54) with main (1fcf56c)}

Summary

✅ 33 untouched
⏩ 4 skipped¹

Footnotes

1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull Request Overview

This PR refactors the handling of TypeScript type cast nodes by extracting the detection logic into a separate function, improving code reusability and maintainability.

Key changes:

• Extracted type cast node detection logic into a new is_type_cast_node helper function
• Simplified format_type_cast_comment_node by utilizing the new helper
• Moved and improved the matches_pattern_at helper function inside the is_type_cast_comment method

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_formatter/src/utils/typecast.rs	Introduces is_type_cast_node helper function and refactors format_type_cast_comment_node to use it
crates/oxc_formatter/src/utils/member_chain/mod.rs	Replaces inline type cast detection logic with call to new is_type_cast_node helper
crates/oxc_formatter/src/formatter/comments.rs	Moves matches_pattern_at helper inside is_type_cast_comment method and updates implementation

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[graphite-app]

Merge activity

• Oct 21, 4:36 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Oct 21, 4:42 AM UTC: Merged by the Graphite merge queue.