feat(formatter): wrap parenthesis for AssignmentExpression that are inside ComputedMemberExpression
#14834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
force-pushed
the
10-21-feat_formatter_wrap_parenthesis_for_assignmentexpression_that_are_inside_computedmemberexpression
branch
from
f4c99f6 to
b615b0a
Compare
CodSpeed Performance ReportMerging #14834 will not alter performanceComparing Summary
Footnotes
|
Member
Merge activity
|
… inside `ComputedMemberExpression` (#14834) related: #14669 (reply in thread)
graphite-app
bot
force-pushed
the
10-21-fix_formatter_correct_handling_of_ignore_comment_for_tsuniontype_and_tsmappedtype
branch
from
5f4b01f to
88fb768
Compare
graphite-app
bot
force-pushed
the
10-21-feat_formatter_wrap_parenthesis_for_assignmentexpression_that_are_inside_computedmemberexpression
branch
from
b615b0a to
aa024d9
Compare
Base automatically changed from
10-21-fix_formatter_correct_handling_of_ignore_comment_for_tsuniontype_and_tsmappedtype
to
main
October 21, 2025 04:44
graphite-app
bot
deleted the
10-21-feat_formatter_wrap_parenthesis_for_assignmentexpression_that_are_inside_computedmemberexpression
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
## [0.7.0] - 2025-10-21 ### 🚀 Features - 6dfcd80 oxfmt: Search both .json and .jsonc config file (#14848) (leaysgur) - aa024d9 formatter: Wrap parenthesis for `AssignmentExpression` that are inside `ComputedMemberExpression` (#14834) (Dunqing) ### 🐛 Bug Fixes - 88fb768 formatter: Correct handling of ignore comment for `TSUnionType` and `TSMappedType` (#14824) (Dunqing) - f7727c7 formatter: Ignore comment doesn't work for the expression statement (#14817) (Dunqing) - 7a420a1 oxfmt: Handle `.d.ts` file correctly (#14835) (leaysgur) ### 🚜 Refactor - 6fa7420 oxfmt: Use custom ignore builder (#14850) (leaysgur) - 9d914a3 formatter: Improve comments handling (#14816) (Dunqing) - f52863d formatter: Improve handling of type cast node (#14815) (Dunqing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #14669 (reply in thread)