Skip to content

fix(formatter): ignore comment doesn't work for the expression statement #14817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

fix(formatter): ignore comment doesn't work for the expression statement #14817

merged 1 commit into from
Oct 21, 2025

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 20, 2025 •
edited
Loading

@github-actions github-actions bot added A-ast-tools Area - AST tools A-formatter Area - Formatter C-bug Category - Bug labels Oct 20, 2025
This was referenced Oct 20, 2025
Merged
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Oct 20, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #14817 will not alter performance

Comparing 10-20-fix_formatter_ignore_comment_doesn_t_work_for_the_expression_statement (de68c72) with main (1fcf56c)1

Summary

✅ 33 untouched
⏩ 4 skipped2

Footnotes

  1. No successful run was found on 10-20-refactor_formatter_improve_comments_handling (354f0c5) during the generation of this report, so main (1fcf56c) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dunqing Dunqing mentioned this pull request Oct 20, 2025
Merged
@Dunqing Dunqing marked this pull request as ready for review October 20, 2025 16:38
@Dunqing Dunqing mentioned this pull request Oct 21, 2025
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 10-20-refactor_formatter_improve_comments_handling branch from 354f0c5 to 9d914a3 Compare October 21, 2025 04:37
@graphite-app graphite-app bot force-pushed the 10-20-fix_formatter_ignore_comment_doesn_t_work_for_the_expression_statement branch from de68c72 to f7727c7 Compare October 21, 2025 04:37
Base automatically changed from 10-20-refactor_formatter_improve_comments_handling to main October 21, 2025 04:42
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 21, 2025
@graphite-app graphite-app bot merged commit f7727c7 into main Oct 21, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-20-fix_formatter_ignore_comment_doesn_t_work_for_the_expression_statement branch October 21, 2025 04:43
@Boshen Boshen mentioned this pull request Oct 21, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Oct 21, 2025
@Boshen
release(oxfmt): v0.7.0 (#14851)
f3b75c3 
## [0.7.0] - 2025-10-21

### 🚀 Features

- 6dfcd80 oxfmt: Search both .json and .jsonc config file (#14848) (leaysgur)
- aa024d9 formatter: Wrap parenthesis for `AssignmentExpression` that are inside `ComputedMemberExpression` (#14834) (Dunqing)

### 🐛 Bug Fixes

- 88fb768 formatter: Correct handling of ignore comment for `TSUnionType` and `TSMappedType` (#14824) (Dunqing)
- f7727c7 formatter: Ignore comment doesn't work for the expression statement (#14817) (Dunqing)
- 7a420a1 oxfmt: Handle `.d.ts` file correctly (#14835) (leaysgur)

### 🚜 Refactor

- 6fa7420 oxfmt: Use custom ignore builder (#14850) (leaysgur)
- 9d914a3 formatter: Improve comments handling (#14816) (Dunqing)
- f52863d formatter: Improve handling of type cast node (#14815) (Dunqing)
@sapphi-red sapphi-red mentioned this pull request Oct 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

No one assigned

Labels

A-ast-tools Area - AST tools A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

formatter: support ignore comments before expression statements

2 participants

@Dunqing