fix(ast-tools): use oxfmt to format generated code #15064

camc314 · 2025-10-29T10:15:14Z

a8e5181#diff-dc1a48ba0d3878494d547c7c5fb975720dddac4966c510f9babec50161110538 broke ast tools generation.

This PR uses oxfmt to format the generated ast files

camc314 · 2025-10-29T10:15:29Z

fix(ast-tools): use oxfmt to format generated code #15064 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

tasks/ast_tools/src/output/javascript.rs

camc314 · 2025-10-29T10:31:54Z

@Dunqing @leaysgur please take a look at this when you have time

Copilot

Pull Request Overview

This PR migrates the JavaScript/TypeScript code formatting from dprint to oxfmt and applies formatting changes across generated JavaScript files. The changes include:

Replacing dprint with oxfmt for formatting generated JavaScript/TypeScript code
Applying consistent formatting via oxfmt to all generated JavaScript files
Code style updates including parentheses for assignments, multi-line variable declarations, and consistent spacing

Reviewed Changes

Copilot reviewed 1 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tasks/ast_tools/src/output/javascript.rs	Migrates formatter from `dprint` (stdin/stdout) to `oxfmt` (file-based)
npm/oxc-types/types.d.ts	Formatting changes to type intersection syntax
napi/parser/generated/visit/walk.js	Formatting changes including brace placement and variable declarations
napi/parser/generated/lazy/walk.js	Formatting updates for variable declarations and control flow statements
napi/parser/generated/lazy/constructors.js	Adds parentheses around assignment expressions in return statements
napi/parser/generated/deserialize/ts_range.js	Multi-line variable declarations and consistent spacing
napi/parser/generated/deserialize/ts.js	Multi-line variable declarations and consistent spacing
napi/parser/generated/deserialize/js_range.js	Multi-line variable declarations and consistent spacing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tasks/ast_tools/src/output/javascript.rs

leaysgur

Ah, sorry! I wasn’t aware of this usecase.

Thanks & it seems good to me.
(Using oxc_formatter crate instead of creating tmp file may be possible but it seems too much?)

leaysgur · 2025-10-29T11:51:30Z

Merge activity

Oct 29, 11:51 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 29, 11:51 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Oct 29, 11:56 AM UTC: Merged by the Graphite merge queue.

a8e5181#diff-dc1a48ba0d3878494d547c7c5fb975720dddac4966c510f9babec50161110538 broke ast tools generation. This PR uses oxfmt to format the generated ast files

camc314 · 2025-10-29T11:52:36Z

(Using oxc_formatter crate instead of creating tmp file may be possible but it seems too much?)

I thought about it, but it means we have to compile more code here, which would proably slow down CI even more.

## [1.25.0] - 2025-10-30 ### 💥 BREAKING CHANGES - 659fd37 linter: [**BREAKING**] `tsgolint`: request fixes when necessary (#15048) (camchenry) ### 🚀 Features - ed24d60 linter: Expose tsgolint program diagnostics (#15080) (camc314) - 23660c9 linter: `tsgolint`: handle omitted fixes and suggestions (#15047) (camchenry) - f7bef73 linter/plugins: Scope manager API (#14890) (Arsh) - 3e15cdd linter/strict-boolean-expression: Add rule (#14930) (camc314) - bd74603 linter: Add support for vitest/valid-title rule (#12085) (Tyler Earls) ### 🐛 Bug Fixes - e41dee5 linter/consistent-type-definition: Skip comments when looking for token (#14909) (camc314) - 806f9ba linter: Search system PATH for tsgolint executable (#14861) (magic-akari) - ee68089 linter: Normalize JS plugin names (#15010) (Peter Wagenet) - 597340e ast-tools: Use oxfmt to format generated code (#15064) (camc314) - 5eaaa8e linter: Prevent underflow in count_comment_lines for JSX files (#15026) (ityuany) - 88577a8 import/no-namespace: Remove dot special case (#15032) (Arsh) - 55ee962 linter/vars-on-top: False positive with typescript declare block (#14952) (Hamir Mahal) - 2de9f39 linter/plugins: Fall back to package name if meta.name is missing (#14938) (Peter Wagenet) - 5ace84b linter/no-empty-object-type: Parse `"allowWithName"` as regular expressions (#14943) (Arsh) - 5a2832d editor: Stop client when delete .oxlintrc.json with `oxc.requireConfig` (#14897) (Liang Mi) - 3e29d23 linter: Use aliases when parsing cli rules (#14912) (Arsh) - b94b6aa linter/explicit-module-boundary-types: False negative with export default function (#14905) (camc314) - 7060863 linter/no-standaline-expect: False positive with expect in callback (#14902) (camc314) - dc5a71b linter/no-accumulating-spread: False positive in nested callbacks within reduce (#14898) (camc314) ### 🚜 Refactor - 8d8d508 editor: Flatten `flags` options (#15006) (Sysix) - b1e1531 language_server: Extract library interface from main.rs (#15036) (Boshen) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - b55df7f language_server: Move sub option for `flags` to the root + deprecate flags (#14933) (Sysix) ### 📚 Documentation - e15c91c linter: Add configuration option docs for eslint/init-declarations rule. (#15085) (Connor Shea) - f4505bc linter: Add configuration option docs for eslint/id-length rule. (#15083) (Connor Shea) - dd4c9d2 linter: Add configuration option docs for eslint/getter-return rule. (#15081) (Connor Shea) - 008e67a linter: Add configuration option docs for jest/no-large-snapshots rule. (#15079) (Connor Shea) - 31daf79 linter: Add configuration option docs for import/no-commonjs rule. (#15077) (Connor Shea) - 9bf8ebe linter: Add configuration option docs for jsdoc/check-tag-names rule. (#15076) (Connor Shea) - 491ab5e linter: Add configuration option docs for jsdoc/no-defaults rule. (#15074) (Connor Shea) - 2602d7e linter: Add configuration option docs for jsdoc/empty-tags rule. (#15072) (Connor Shea) - c3a92e0 linter: Add configuration option docs for oxc/no-rest-spread-properties rule. (#15070) (Connor Shea) - c7c9213 linter: Add configuration option docs for oxc/no-optional-chaining rule. (#15071) (Connor Shea) - 47a616f linter: Add configuration option docs for typescript/no-empty-object-type rule. (#14968) (Connor Shea) - fcc1e25 linter: Add configuration option docs for typescript/no-explicit-any rule. (#15051) (Connor Shea) - 1b88934 linter: Add configuration option docs for eslint/no-multi-assign rule. (#15052) (Connor Shea) - 909d4b9 linter: Add configuration option docs for eslint/no-unsafe-negation rule. (#15053) (Connor Shea) - f60763b linter: Add configuration option docs for eslint/no-useless-computed-key rule. (#15054) (Connor Shea) - c8911d4 linter: Add configuration option docs for eslint/no-unneeded-ternary rule. (#15056) (Connor Shea) - 9fc6374 linter: Add configuration option docs for eslint/no-misleading-character-class rule. (#15058) (Connor Shea) - 7656e2b linter: Add configuration option docs for eslint/sort-imports rule. (#15013) (Connor Shea) - bb06039 linter: Add configuration option docs for unicorn/no-instanceof-builtins rule. (#14999) (Connor Shea) - a4af5ff linter: Add configuration option docs for unicorn/no-typeof-undefined rule. (#15001) (Connor Shea) - ac2ed39 linter: Add configuration option docs for unicorn/numeric-separators-style rule. (#15002) (Connor Shea) - 5ce3e33 linter: Add configuration option docs for unicorn/prefer-object-from-entries rule. (#15003) (Connor Shea) - 07aea72 linter: Add configuration option docs for eslint/sort-keys rule. (#15014) (Connor Shea) - 35b36e0 linter: Add configuration option docs for eslint/no-eval rule. (#15015) (Connor Shea) - d222b85 linter: Add configuration option docs for eslint/no-empty rule. (#15017) (Connor Shea) - 83bbc37 linter: Add configuration option docs for eslint/no-extend-native rule. (#15018) (Connor Shea) - aade2fe linter: Add configuration option docs for eslint/no-extra-boolean-cast rule. (#15019) (Connor Shea) - bae0c09 linter: Add configuration option docs for jsdoc/require-yields rule. (#15024) (Connor Shea) - 06c77b6 linter: Add configuration option docs for unicorn/prefer-at rule. (#15023) (Connor Shea) - 54b2cb4 linter: Add configuration option docs for eslint/max-classes-per-file rule. (#15022) (Connor Shea) - b5acda7 linter: Add configuration option docs for typescript/explicit-module-boundary-types rule. (#15021) (Connor Shea) - a0c6162 linter: Add configuration option docs for vue/max-props rule. (#14966) (Connor Shea) - 3ec59c0 linter: Add configuration option docs for no-async-endpoint-handlers rule. (#14965) (Connor Shea) - 7a275fd linter: Add configuration option docs for no-map-spread rule. (#14964) (Connor Shea) - 0002b7c linter: Add configuration option docs for no-barrel-file rule. (#14963) (Connor Shea) - fd4b7ab linter: Add configuration option docs for unicorn/consistent-function-scoping rule. (#14969) (Connor Shea) - aa339b3 linter: Add configuration option docs for eslint/no-void rule. (#14970) (Connor Shea) - af8bdae linter: Add configuration option docs for import/no-anonymous-default-export rule. (#14971) (Connor Shea) - 5a81953 linter: Add configuration option docs for jest/require-hook rule. (#14972) (Connor Shea) - 1be268d linter: Add configuration option docs for jest/require-top-level-describe rule. (#14973) (Connor Shea) - 860a58c linter: Add configuration option docs for jest/no-hooks rule. (#14974) (Connor Shea) - b69b586 linter: Add configuration option docs for jest/max-expects rule. (#14975) (Connor Shea) - 2e02fe0 linter: Add configuration option docs for jest/no-deprecated-functions rule (#14976) (Connor Shea) - cdc6c4f linter: Add configuration option docs for unicorn/no-array-sort rule. (#14977) (Connor Shea) - 40eb394 linter/no-unassigned-import-config: Add auto generated config docs (#14918) (camc314) ### ⚡ Performance - a9f68b2 linter: Move up rule retainment into initial collection to reduce allocation size (#14822) (camchenry) - b27c5b9 linter: Add codegen support for regex nodes (#14874) (camchenry) ### 🧪 Testing - bf898e5 linter: Increase stability of tsgolint test cases (#15063) (camc314) - 49da411 linter/no-standalone-expect: Fix tests (#14901) (camc314) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

camc314 changed the title ~~fix(ast-tools): use oxfmt to format~~ fix(ast-tools): use oxfmt to format generated code Oct 29, 2025

github-actions bot added A-ast-tools Area - AST tools C-bug Category - Bug labels Oct 29, 2025

camc314 force-pushed the c/10-29-fix_ast-tools_use_oxfmt_to_format branch from aac2930 to fab2568 Compare October 29, 2025 10:29

github-actions bot added A-linter Area - Linter A-parser Area - Parser A-cli Area - CLI labels Oct 29, 2025

camc314 assigned Dunqing and leaysgur Oct 29, 2025

camc314 commented Oct 29, 2025

View reviewed changes

tasks/ast_tools/src/output/javascript.rs Show resolved Hide resolved

camc314 marked this pull request as ready for review October 29, 2025 10:31

camc314 requested a review from overlookmotel as a code owner October 29, 2025 10:31

Copilot AI review requested due to automatic review settings October 29, 2025 10:31

camc314 mentioned this pull request Oct 29, 2025

fix(linter): normalize JS plugin names #15010

Merged

Copilot AI reviewed Oct 29, 2025

View reviewed changes

tasks/ast_tools/src/output/javascript.rs Show resolved Hide resolved

tasks/ast_tools/src/output/javascript.rs Show resolved Hide resolved

leaysgur approved these changes Oct 29, 2025

View reviewed changes

leaysgur added the 0-merge Merge with Graphite Merge Queue label Oct 29, 2025

fix(ast-tools): use oxfmt to format generated code (#15064)

597340e

a8e5181#diff-dc1a48ba0d3878494d547c7c5fb975720dddac4966c510f9babec50161110538 broke ast tools generation. This PR uses oxfmt to format the generated ast files

graphite-app bot force-pushed the c/10-29-fix_ast-tools_use_oxfmt_to_format branch from fab2568 to 597340e Compare October 29, 2025 11:51

graphite-app bot merged commit 597340e into main Oct 29, 2025
18 checks passed

graphite-app bot deleted the c/10-29-fix_ast-tools_use_oxfmt_to_format branch October 29, 2025 11:56

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 29, 2025

Boshen mentioned this pull request Oct 30, 2025

release(oxlint): v1.25.0 #15087

Merged

Boshen mentioned this pull request Oct 30, 2025

release(crates): v0.96.0 #15115

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(ast-tools): use oxfmt to format generated code #15064

fix(ast-tools): use oxfmt to format generated code #15064

Uh oh!

camc314 commented Oct 29, 2025 •

edited

Loading

Uh oh!

camc314 commented Oct 29, 2025

Uh oh!

Uh oh!

camc314 commented Oct 29, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

leaysgur left a comment

Uh oh!

leaysgur commented Oct 29, 2025 •

edited by graphite-app bot

Loading

Uh oh!

camc314 commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

fix(ast-tools): use oxfmt to format generated code #15064

fix(ast-tools): use oxfmt to format generated code #15064

Uh oh!

Conversation

camc314 commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Oct 29, 2025

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

camc314 commented Oct 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

leaysgur left a comment

Choose a reason for hiding this comment

Uh oh!

leaysgur commented Oct 29, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

camc314 commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camc314 commented Oct 29, 2025 •

edited

Loading

leaysgur commented Oct 29, 2025 •

edited by graphite-app bot

Loading