feat(linter): expose tsgolint program diagnostics #15080

camc314 · 2025-10-29T23:30:20Z

No description provided.

camc314 · 2025-10-29T23:30:36Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-10-30T00:29:57Z

CodSpeed Performance Report

Merging #15080 will not alter performance

_{Comparing c/10-29-feat_expose_program_diagnostics (45eaaa9) with 10-28-feat_linter_tsgolint_request_fixes_when_necessary (658d748)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

No successful run was found on 10-28-feat_linter_tsgolint_request_fixes_when_necessary (1f8f979) during the generation of this report, so e75ecf4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull Request Overview

This PR adds support for handling internal diagnostics from the tsgolint binary by introducing a new diagnostic type system. Previously, only rule diagnostics were supported; now both rule diagnostics and internal errors (like configuration errors) can be properly handled and reported.

Key changes:

Introduced a TsGoLintDiagnostic enum with Rule and Internal variants to distinguish between rule violations and internal errors
Added DiagnosticKind discriminator for serialization/deserialization of different diagnostic types
Modified the payload structure to support optional fields based on diagnostic kind
Removed system PATH search for the tsgolint executable, restricting lookup to environment variable and node_modules/.bin

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
crates/oxc_linter/src/tsgolint.rs	Core implementation: adds diagnostic type discrimination, refactors handling logic to process internal diagnostics, updates payload structure, removes PATH search, and removes obsolete test
apps/oxlint/src/lint.rs	Adds test for configuration error handling
apps/oxlint/src/snapshots/fixtures__tsgolint_config_error_--type-aware@oxlint.snap	Expected test output snapshot for config error scenario
apps/oxlint/fixtures/tsgolint_config_error/tsconfig.json	Test fixture with invalid TypeScript configuration
apps/oxlint/fixtures/tsgolint_config_error/index.ts	Empty test file for config error scenario

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/oxlint/fixtures/tsgolint_config_error/tsconfig.json

crates/oxc_linter/src/tsgolint.rs

camc314 · 2025-10-30T00:37:46Z

Merge activity

Oct 30, 12:37 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 30, 12:51 AM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 30, 12:57 AM UTC: Merged by the Graphite merge queue.

## [1.25.0] - 2025-10-30 ### 💥 BREAKING CHANGES - 659fd37 linter: [**BREAKING**] `tsgolint`: request fixes when necessary (#15048) (camchenry) ### 🚀 Features - ed24d60 linter: Expose tsgolint program diagnostics (#15080) (camc314) - 23660c9 linter: `tsgolint`: handle omitted fixes and suggestions (#15047) (camchenry) - f7bef73 linter/plugins: Scope manager API (#14890) (Arsh) - 3e15cdd linter/strict-boolean-expression: Add rule (#14930) (camc314) - bd74603 linter: Add support for vitest/valid-title rule (#12085) (Tyler Earls) ### 🐛 Bug Fixes - e41dee5 linter/consistent-type-definition: Skip comments when looking for token (#14909) (camc314) - 806f9ba linter: Search system PATH for tsgolint executable (#14861) (magic-akari) - ee68089 linter: Normalize JS plugin names (#15010) (Peter Wagenet) - 597340e ast-tools: Use oxfmt to format generated code (#15064) (camc314) - 5eaaa8e linter: Prevent underflow in count_comment_lines for JSX files (#15026) (ityuany) - 88577a8 import/no-namespace: Remove dot special case (#15032) (Arsh) - 55ee962 linter/vars-on-top: False positive with typescript declare block (#14952) (Hamir Mahal) - 2de9f39 linter/plugins: Fall back to package name if meta.name is missing (#14938) (Peter Wagenet) - 5ace84b linter/no-empty-object-type: Parse `"allowWithName"` as regular expressions (#14943) (Arsh) - 5a2832d editor: Stop client when delete .oxlintrc.json with `oxc.requireConfig` (#14897) (Liang Mi) - 3e29d23 linter: Use aliases when parsing cli rules (#14912) (Arsh) - b94b6aa linter/explicit-module-boundary-types: False negative with export default function (#14905) (camc314) - 7060863 linter/no-standaline-expect: False positive with expect in callback (#14902) (camc314) - dc5a71b linter/no-accumulating-spread: False positive in nested callbacks within reduce (#14898) (camc314) ### 🚜 Refactor - 8d8d508 editor: Flatten `flags` options (#15006) (Sysix) - b1e1531 language_server: Extract library interface from main.rs (#15036) (Boshen) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - b55df7f language_server: Move sub option for `flags` to the root + deprecate flags (#14933) (Sysix) ### 📚 Documentation - e15c91c linter: Add configuration option docs for eslint/init-declarations rule. (#15085) (Connor Shea) - f4505bc linter: Add configuration option docs for eslint/id-length rule. (#15083) (Connor Shea) - dd4c9d2 linter: Add configuration option docs for eslint/getter-return rule. (#15081) (Connor Shea) - 008e67a linter: Add configuration option docs for jest/no-large-snapshots rule. (#15079) (Connor Shea) - 31daf79 linter: Add configuration option docs for import/no-commonjs rule. (#15077) (Connor Shea) - 9bf8ebe linter: Add configuration option docs for jsdoc/check-tag-names rule. (#15076) (Connor Shea) - 491ab5e linter: Add configuration option docs for jsdoc/no-defaults rule. (#15074) (Connor Shea) - 2602d7e linter: Add configuration option docs for jsdoc/empty-tags rule. (#15072) (Connor Shea) - c3a92e0 linter: Add configuration option docs for oxc/no-rest-spread-properties rule. (#15070) (Connor Shea) - c7c9213 linter: Add configuration option docs for oxc/no-optional-chaining rule. (#15071) (Connor Shea) - 47a616f linter: Add configuration option docs for typescript/no-empty-object-type rule. (#14968) (Connor Shea) - fcc1e25 linter: Add configuration option docs for typescript/no-explicit-any rule. (#15051) (Connor Shea) - 1b88934 linter: Add configuration option docs for eslint/no-multi-assign rule. (#15052) (Connor Shea) - 909d4b9 linter: Add configuration option docs for eslint/no-unsafe-negation rule. (#15053) (Connor Shea) - f60763b linter: Add configuration option docs for eslint/no-useless-computed-key rule. (#15054) (Connor Shea) - c8911d4 linter: Add configuration option docs for eslint/no-unneeded-ternary rule. (#15056) (Connor Shea) - 9fc6374 linter: Add configuration option docs for eslint/no-misleading-character-class rule. (#15058) (Connor Shea) - 7656e2b linter: Add configuration option docs for eslint/sort-imports rule. (#15013) (Connor Shea) - bb06039 linter: Add configuration option docs for unicorn/no-instanceof-builtins rule. (#14999) (Connor Shea) - a4af5ff linter: Add configuration option docs for unicorn/no-typeof-undefined rule. (#15001) (Connor Shea) - ac2ed39 linter: Add configuration option docs for unicorn/numeric-separators-style rule. (#15002) (Connor Shea) - 5ce3e33 linter: Add configuration option docs for unicorn/prefer-object-from-entries rule. (#15003) (Connor Shea) - 07aea72 linter: Add configuration option docs for eslint/sort-keys rule. (#15014) (Connor Shea) - 35b36e0 linter: Add configuration option docs for eslint/no-eval rule. (#15015) (Connor Shea) - d222b85 linter: Add configuration option docs for eslint/no-empty rule. (#15017) (Connor Shea) - 83bbc37 linter: Add configuration option docs for eslint/no-extend-native rule. (#15018) (Connor Shea) - aade2fe linter: Add configuration option docs for eslint/no-extra-boolean-cast rule. (#15019) (Connor Shea) - bae0c09 linter: Add configuration option docs for jsdoc/require-yields rule. (#15024) (Connor Shea) - 06c77b6 linter: Add configuration option docs for unicorn/prefer-at rule. (#15023) (Connor Shea) - 54b2cb4 linter: Add configuration option docs for eslint/max-classes-per-file rule. (#15022) (Connor Shea) - b5acda7 linter: Add configuration option docs for typescript/explicit-module-boundary-types rule. (#15021) (Connor Shea) - a0c6162 linter: Add configuration option docs for vue/max-props rule. (#14966) (Connor Shea) - 3ec59c0 linter: Add configuration option docs for no-async-endpoint-handlers rule. (#14965) (Connor Shea) - 7a275fd linter: Add configuration option docs for no-map-spread rule. (#14964) (Connor Shea) - 0002b7c linter: Add configuration option docs for no-barrel-file rule. (#14963) (Connor Shea) - fd4b7ab linter: Add configuration option docs for unicorn/consistent-function-scoping rule. (#14969) (Connor Shea) - aa339b3 linter: Add configuration option docs for eslint/no-void rule. (#14970) (Connor Shea) - af8bdae linter: Add configuration option docs for import/no-anonymous-default-export rule. (#14971) (Connor Shea) - 5a81953 linter: Add configuration option docs for jest/require-hook rule. (#14972) (Connor Shea) - 1be268d linter: Add configuration option docs for jest/require-top-level-describe rule. (#14973) (Connor Shea) - 860a58c linter: Add configuration option docs for jest/no-hooks rule. (#14974) (Connor Shea) - b69b586 linter: Add configuration option docs for jest/max-expects rule. (#14975) (Connor Shea) - 2e02fe0 linter: Add configuration option docs for jest/no-deprecated-functions rule (#14976) (Connor Shea) - cdc6c4f linter: Add configuration option docs for unicorn/no-array-sort rule. (#14977) (Connor Shea) - 40eb394 linter/no-unassigned-import-config: Add auto generated config docs (#14918) (camc314) ### ⚡ Performance - a9f68b2 linter: Move up rule retainment into initial collection to reduce allocation size (#14822) (camchenry) - b27c5b9 linter: Add codegen support for regex nodes (#14874) (camchenry) ### 🧪 Testing - bf898e5 linter: Increase stability of tsgolint test cases (#15063) (camc314) - 49da411 linter/no-standalone-expect: Fix tests (#14901) (camc314) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Oct 29, 2025

camc314 force-pushed the c/10-29-feat_expose_program_diagnostics branch from f275298 to 767272a Compare October 30, 2025 00:18

camc314 changed the base branch from main to graphite-base/15080 October 30, 2025 00:21

camc314 force-pushed the c/10-29-feat_expose_program_diagnostics branch from 767272a to e37d631 Compare October 30, 2025 00:21

camc314 changed the base branch from graphite-base/15080 to 10-28-feat_linter_tsgolint_request_fixes_when_necessary October 30, 2025 00:21

This was referenced Oct 30, 2025

feat(linter)!: tsgolint: request fixes when necessary #15048

Merged

chore(deps): update dependency oxlint-tsgolint to v0.4.0 #15082

Merged

camc314 force-pushed the 10-28-feat_linter_tsgolint_request_fixes_when_necessary branch from 0763baa to 4110d01 Compare October 30, 2025 00:22

camc314 force-pushed the c/10-29-feat_expose_program_diagnostics branch from e37d631 to 45eaaa9 Compare October 30, 2025 00:22

graphite-app bot changed the base branch from 10-28-feat_linter_tsgolint_request_fixes_when_necessary to graphite-base/15080 October 30, 2025 00:27

camc314 changed the title ~~feat: expose program diagnostics~~ feat(linter): expose tsgolint program diagnostics Oct 30, 2025

github-actions bot added the C-enhancement Category - New feature or request label Oct 30, 2025

camc314 force-pushed the c/10-29-feat_expose_program_diagnostics branch from 45eaaa9 to 4b0c9c9 Compare October 30, 2025 00:29

camc314 force-pushed the graphite-base/15080 branch from 4110d01 to 659fd37 Compare October 30, 2025 00:29

camc314 changed the base branch from graphite-base/15080 to 10-28-feat_linter_tsgolint_request_fixes_when_necessary October 30, 2025 00:29

camc314 force-pushed the c/10-29-feat_expose_program_diagnostics branch from 4b0c9c9 to 1139505 Compare October 30, 2025 00:30

Base automatically changed from 10-28-feat_linter_tsgolint_request_fixes_when_necessary to main October 30, 2025 00:32

camc314 marked this pull request as ready for review October 30, 2025 00:33

Copilot AI review requested due to automatic review settings October 30, 2025 00:33

camc314 force-pushed the c/10-29-feat_expose_program_diagnostics branch from 1139505 to 3dbf526 Compare October 30, 2025 00:36

Copilot AI reviewed Oct 30, 2025

View reviewed changes

apps/oxlint/fixtures/tsgolint_config_error/tsconfig.json Show resolved Hide resolved

crates/oxc_linter/src/tsgolint.rs Outdated Show resolved Hide resolved

crates/oxc_linter/src/tsgolint.rs Show resolved Hide resolved

camc314 force-pushed the c/10-29-feat_expose_program_diagnostics branch 3 times, most recently from 2e4d3f5 to 2ec34ac Compare October 30, 2025 00:37

camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 30, 2025

camc314 force-pushed the c/10-29-feat_expose_program_diagnostics branch from 2ec34ac to 4c9de15 Compare October 30, 2025 00:39

camc314 force-pushed the c/10-29-feat_expose_program_diagnostics branch 3 times, most recently from 7f3d56f to 0b1109f Compare October 30, 2025 00:46

feat(linter): expose tsgolint program diagnostics (#15080)

ed24d60

graphite-app bot force-pushed the c/10-29-feat_expose_program_diagnostics branch from 0b1109f to ed24d60 Compare October 30, 2025 00:51

graphite-app bot merged commit ed24d60 into main Oct 30, 2025
20 checks passed

graphite-app bot deleted the c/10-29-feat_expose_program_diagnostics branch October 30, 2025 00:57

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 30, 2025

Boshen mentioned this pull request Oct 30, 2025

release(oxlint): v1.25.0 #15087

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(linter): expose tsgolint program diagnostics #15080

feat(linter): expose tsgolint program diagnostics #15080

Uh oh!

camc314 commented Oct 29, 2025

Uh oh!

camc314 commented Oct 29, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 commented Oct 30, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(linter): expose tsgolint program diagnostics #15080

feat(linter): expose tsgolint program diagnostics #15080

Uh oh!

Conversation

camc314 commented Oct 29, 2025

Uh oh!

camc314 commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Oct 30, 2025

CodSpeed Performance Report

Merging #15080 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 commented Oct 30, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Oct 29, 2025 •

edited

Loading

camc314 commented Oct 30, 2025 •

edited by graphite-app bot

Loading