-
-
Notifications
You must be signed in to change notification settings - Fork 722
fix(parser): reject for (let.something of ...)
#15220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
11-02-fix_parser_reject_for_let.something_of_._
Nov 2, 2025
Merged
fix(parser): reject for (let.something of ...)
#15220
graphite-app
merged 1 commit into
main
from
11-02-fix_parser_reject_for_let.something_of_._
Nov 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
CodSpeed Performance ReportMerging #15220 will not alter performanceComparing Summary
|
560105b to
28ee313
Compare
55ed2eb to
d6539ee
Compare
This was referenced Nov 2, 2025
Contributor
Merge activity
|
Reject cases like `for (let.something of ...)`. TIL that this is not allowed. `for (let of ...)` was already rejected but these cases were not handled.
d6539ee to
97ab60d
Compare
28ee313 to
2d6d3a8
Compare
Base automatically changed from
11-02-fix_parser_reject_invalid_assignment_operator_in_assignment_targets
to
main
November 2, 2025 12:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Reject cases like
for (let.something of ...). TIL that this is not allowed.for (let of ...)was already rejected but these cases were not handled.