Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 2, 2025

Reject cases like for (let.something of ...). TIL that this is not allowed.
for (let of ...) was already rejected but these cases were not handled.

Copy link
Member Author

sapphi-red commented Nov 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 2, 2025

CodSpeed Performance Report

Merging #15220 will not alter performance

Comparing 11-02-fix_parser_reject_for_let.something_of_._ (28ee313) with 11-02-fix_parser_reject_invalid_assignment_operator_in_assignment_targets (d6539ee)

Summary

✅ 37 untouched

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 2, 2025

Merge activity

Reject cases like `for (let.something of ...)`. TIL that this is not allowed.
`for (let of ...)` was already rejected but these cases were not handled.
@graphite-app graphite-app bot force-pushed the 11-02-fix_parser_reject_invalid_assignment_operator_in_assignment_targets branch from d6539ee to 97ab60d Compare November 2, 2025 12:09
@graphite-app graphite-app bot force-pushed the 11-02-fix_parser_reject_for_let.something_of_._ branch from 28ee313 to 2d6d3a8 Compare November 2, 2025 12:10
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 2, 2025
Base automatically changed from 11-02-fix_parser_reject_invalid_assignment_operator_in_assignment_targets to main November 2, 2025 12:15
@graphite-app graphite-app bot merged commit 2d6d3a8 into main Nov 2, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 11-02-fix_parser_reject_for_let.something_of_._ branch November 2, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants